WinDDK ATL and MSVC express compatability

chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autocomplete/autocomplete_result_view.h"
 
+#ifdef COMPILER_MSVCEXPRESS

[Mark Mentovai, 2011/03/16 16:25:20]

I’d like a Windows expert to weigh in on whether doing these #includes early for
COMPILER_MSVCEXPRESS is right, or if there’s something else to key off here.

[M-A Ruel, 2011/03/16 17:48:55]

I'd favor something that doesn't need fixes like this if possible because the
only thing I know for sure is that it'll keep on breaking.

[RN, 2011/03/17 06:33:25]

It's not exclusive to the express versions, just the Windows DDK's version of
the ATL. Therefore, I'm taking a different approach and eliminating the ifdefs
and making a include for when other people are using non-DDK ATL versions to
toss warnings/errors when the include order is wrong (a.k.a. when the
atlbase+atlwin combo is needed explicitly in the source file). This way, the
Chromium devs won't have to worry about breaking that aspect of the express
compilation process.

+#include <atlbase.h>
+#include <atlwin.h>  // Avoid WinDDK intsafe.h/XINTXX_MIN/MAX conflicts
+#endif
+
 #include "base/i18n/bidi_line_iterator.h"
 #include "chrome/browser/ui/views/autocomplete/autocomplete_result_view_model.h"
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/base/text/text_elider.h"
 #include "ui/gfx/canvas_skia.h"
 #include "ui/gfx/color_utils.h"
@@ skipping 472 matching lines @@
       //   * It's normal, and will be able to draw successfully with the
       //     ellipsis we'll append to it, or
       //   * It is also bold, in which case we don't want to fall back
       //     to a normal ellipsis anyway (see comment above).
     }
   }
 
   // We couldn't draw anything.
   runs->clear();
 }