base/win/atlcheck.h - Issue 6676030: WinDDK ATL and MSVC express compatability

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/win/atlcheck.h

Issue 6676030: WinDDK ATL and MSVC express compatability (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Address comments; r78670; make atlcheck.h not pull in header Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_WIN_ATLCHECK_H_

	6 #define BASE_WIN_ATLCHECK_H_

	7

	8 // USAGE: Put after atl headers in all headers; headers only.
	Mark Mentovai 2011/03/18 14:54:47 Put after ATL headers in all headers that include Put after ATL headers in all headers that include ATL RN 2011/03/18 16:39:56 Sounds better, done. Show quoted text On 2011/03/18 14:54:47, Mark Mentovai wrote: > Put after ATL headers in all headers that include ATL Sounds better, done.
	9 //

	10 // Windows DDK 7.1's ATL atlmem.h pulls in intsafe.h which has it's
	Mark Mentovai 2011/03/18 14:54:47 it's -> its it's -> its RN 2011/03/18 16:39:56 Done. Show quoted text On 2011/03/18 14:54:47, Mark Mentovai wrote: > it's -> its Done.
	11 // own version of INT/ETC_MIN/MAX which is not wrapped with an ifdef; thus,

	12 // it needs to be included first. This simulates the include conflicts

	13 // that occur with non-DDK ATL versions.

	14 //

	15 // Various ATL headers such as atlwin.h pull in atlmem.h. Including an ICU

	16 // header before the ATL headers is the most likely source if an error is

	17 // generated.

	18 #if defined(__ATLMEM_H__)

	19 # if defined(INT8_MAX) && !defined(DWORD_ERROR) // DWORD_ERROR is intsafe.h
	Mark Mentovai 2011/03/18 14:54:47 We never indent preprocessor macros at all. Pull a We never indent preprocessor macros at all. Pull all of these guys back so that they’re flush with their opening #. RN 2011/03/18 16:39:56 Yeah, done. While the guidelines said no indentati Show quoted text On 2011/03/18 14:54:47, Mark Mentovai wrote: > We never indent preprocessor macros at all. Pull all of these guys back so that > they’re flush with their opening #. Yeah, done. While the guidelines said no indentation a file search revealed a lot of preprocessor-heavy files were following that indentation convention; mostly "third party" libs like tcmalloc, though base\stl_util-inl.h and a few other Chromium files do it also.
	20 # error Certain ATL headers must be before any third party ones

	21 # endif

	22 #else

	23 # undef BASE_WIN_ATLCHECK_H_ // atlmem.h not included, check again

	24 #endif

	25

	26 #endif // BASE_WIN_ATLCHECK_H_

OLD	NEW

« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »