WinDDK ATL and MSVC express compatability

views/controls/table/table_view_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#if defined(_WIN32) || defined(_WIN64)  // OS_WIN

[Mark Mentovai, 2011/03/17 20:43:42]

Can we #include "build/build_config.h" first and then use OS_WIN for real?

[RN, 2011/03/18 09:34:24]

It's sort of a gray area in the google guidelines I read, but I did this anyway.
Makes it a lot cleaner, but lint doesn't like it.

[Mark Mentovai, 2011/03/18 14:54:47]

RN wrote:
It’s not a gray area as far as I’m concerned. If lint hates it, you should be
able to say // NOLINT on the line where lint believes there’s a violation to
suppress any warnings.

+#include <atlbase.h>
+#include <atlwin.h>

[Mark Mentovai, 2011/03/17 20:43:42]

With this included, don’t you need "base/win/atlcheck.h" too?

[RN, 2011/03/18 09:34:24]

atlcheck.h is just for headers (added more docs to the header itself) to enforce
the header order in the source files when not using the WinDDK ATL.

+#endif

[Mark Mentovai, 2011/03/17 20:43:42]

Blank line after this now.

[RN, 2011/03/18 09:34:24]

Done.

 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/models/table_model.h"
 #include "ui/base/models/table_model_observer.h"
 #include "views/controls/table/table_view.h"
 #include "views/controls/table/table_view2.h"
 #include "views/window/window_delegate.h"
 #if defined(OS_WIN)
 #include "views/window/window_win.h"
 #else
 #include "views/window/window_gtk.h"
 #endif
 
 using ui::TableModel;
-using ui::TableModelObserver; // TODO(beng): remove these
+using ui::TableModelObserver;  // TODO(beng): remove these
 
 // Put the tests in the views namespace to make it easier to declare them as
 // friend classes.
 namespace views {
 
 // TestTableModel --------------------------------------------------------------
 
 // Trivial TableModel implementation that is backed by a vector of vectors.
 // Provides methods for adding/removing/changing the contents that notify the
 // observer appropriately.
@@ skipping 589 matching lines @@
 
   table_->FocusRow(2);
   EXPECT_EQ(2, table_->GetFirstFocusedRow());
 
   table_->ClearRowFocus();
   EXPECT_EQ(-1, table_->GetFirstSelectedRow());
 }
 #endif
 
 }  // namespace views