Issue 6676019: Sample correct registers on solaris

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6676019: Sample correct registers on solaris

Created:
9 years, 9 months ago by ry

Modified:
9 years, 9 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Visibility:
Public.

Description

Sample correct registers on solaris

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -12 lines)			Patch
	M	src/platform-solaris.cc	View		2 chunks	+5 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

We were sampling the wrong registers on Solaris. This patch fixes all of our cctest ...

9 years, 9 months ago (2011-03-11 02:57:26 UTC) #1

Vitaly Repeshko

9 years, 9 months ago (2011-03-11 07:35:52 UTC) #2

On 2011/03/11 02:57:26, ry wrote:
> We were sampling the wrong registers on Solaris. This patch fixes all of our
> cctest crashes.

LGTM. Landed in r7141. Closing code review.

Thanks,
Vitaly

Expand Messages | Collapse Messages