chrome/browser/ui/gtk/location_bar_view_gtk.cc - Issue 6676015: Coverity: Pass values by reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/location_bar_view_gtk.cc

Issue 6676015: Coverity: Pass values by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/location_bar_view_gtk.cc

diff --git a/chrome/browser/ui/gtk/location_bar_view_gtk.cc b/chrome/browser/ui/gtk/location_bar_view_gtk.cc

index d742338ed3866c80fe920a11ca4f4cb6fd260849..e314fe33c65697523466854d2eb9ffce7870ec3c 100644

--- a/chrome/browser/ui/gtk/location_bar_view_gtk.cc

+++ b/chrome/browser/ui/gtk/location_bar_view_gtk.cc

@@ -1475,7 +1475,7 @@ LocationBarViewGtk::PageActionViewGtk::~PageActionViewGtk() {

}

void LocationBarViewGtk::PageActionViewGtk::UpdateVisibility(

- TabContents* contents, GURL url) {

+ TabContents* contents, const GURL& url) {

// Save this off so we can pass it back to the extension when the action gets

// executed. See PageActionImageView::OnMousePressed.

current_tab_id_ = contents ? ExtensionTabUtil::GetTabId(contents) : -1;