Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 6676009: Fix x64 array length operations in Crankshaft (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1773 matching lines...) Expand 10 before | Expand all | Expand 10 after
1784 ASSERT(instr->key()->representation().IsInteger32()); 1784 ASSERT(instr->key()->representation().IsInteger32());
1785 LOperand* obj = UseRegisterAtStart(instr->object()); 1785 LOperand* obj = UseRegisterAtStart(instr->object());
1786 LOperand* key = UseRegisterAtStart(instr->key()); 1786 LOperand* key = UseRegisterAtStart(instr->key());
1787 LLoadKeyedFastElement* result = new LLoadKeyedFastElement(obj, key); 1787 LLoadKeyedFastElement* result = new LLoadKeyedFastElement(obj, key);
1788 return AssignEnvironment(DefineSameAsFirst(result)); 1788 return AssignEnvironment(DefineSameAsFirst(result));
1789 } 1789 }
1790 1790
1791 1791
1792 LInstruction* LChunkBuilder::DoLoadPixelArrayElement( 1792 LInstruction* LChunkBuilder::DoLoadPixelArrayElement(
1793 HLoadPixelArrayElement* instr) { 1793 HLoadPixelArrayElement* instr) {
1794 Abort("Pixel array loads in generated code cause segfaults (danno)");
1795 ASSERT(instr->representation().IsInteger32()); 1794 ASSERT(instr->representation().IsInteger32());
1796 ASSERT(instr->key()->representation().IsInteger32()); 1795 ASSERT(instr->key()->representation().IsInteger32());
1797 LOperand* external_pointer = 1796 LOperand* external_pointer =
1798 UseRegisterAtStart(instr->external_pointer()); 1797 UseRegisterAtStart(instr->external_pointer());
1799 LOperand* key = UseRegisterAtStart(instr->key()); 1798 LOperand* key = UseRegisterAtStart(instr->key());
1800 LLoadPixelArrayElement* result = 1799 LLoadPixelArrayElement* result =
1801 new LLoadPixelArrayElement(external_pointer, key); 1800 new LLoadPixelArrayElement(external_pointer, key);
1802 return DefineSameAsFirst(result); 1801 return DefineSameAsFirst(result);
1803 } 1802 }
1804 1803
(...skipping 21 matching lines...) Expand all
1826 LOperand* key = needs_write_barrier 1825 LOperand* key = needs_write_barrier
1827 ? UseTempRegister(instr->key()) 1826 ? UseTempRegister(instr->key())
1828 : UseRegisterOrConstantAtStart(instr->key()); 1827 : UseRegisterOrConstantAtStart(instr->key());
1829 1828
1830 return AssignEnvironment(new LStoreKeyedFastElement(obj, key, val)); 1829 return AssignEnvironment(new LStoreKeyedFastElement(obj, key, val));
1831 } 1830 }
1832 1831
1833 1832
1834 LInstruction* LChunkBuilder::DoStorePixelArrayElement( 1833 LInstruction* LChunkBuilder::DoStorePixelArrayElement(
1835 HStorePixelArrayElement* instr) { 1834 HStorePixelArrayElement* instr) {
1836 Abort("Pixel array stores in generated code sometimes segfaults (danno)");
1837 ASSERT(instr->value()->representation().IsInteger32()); 1835 ASSERT(instr->value()->representation().IsInteger32());
1838 ASSERT(instr->external_pointer()->representation().IsExternal()); 1836 ASSERT(instr->external_pointer()->representation().IsExternal());
1839 ASSERT(instr->key()->representation().IsInteger32()); 1837 ASSERT(instr->key()->representation().IsInteger32());
1840 1838
1841 LOperand* external_pointer = UseRegister(instr->external_pointer()); 1839 LOperand* external_pointer = UseRegister(instr->external_pointer());
1842 LOperand* val = UseTempRegister(instr->value()); 1840 LOperand* val = UseTempRegister(instr->value());
1843 LOperand* key = UseRegister(instr->key()); 1841 LOperand* key = UseRegister(instr->key());
1844 1842
1845 return new LStorePixelArrayElement(external_pointer, key, val); 1843 return new LStorePixelArrayElement(external_pointer, key, val);
1846 } 1844 }
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
2041 2039
2042 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 2040 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
2043 HEnvironment* outer = current_block_->last_environment()->outer(); 2041 HEnvironment* outer = current_block_->last_environment()->outer();
2044 current_block_->UpdateEnvironment(outer); 2042 current_block_->UpdateEnvironment(outer);
2045 return NULL; 2043 return NULL;
2046 } 2044 }
2047 2045
2048 } } // namespace v8::internal 2046 } } // namespace v8::internal
2049 2047
2050 #endif // V8_TARGET_ARCH_X64 2048 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698