power_LoadTest: Add parameter for custom tasks

power_LoadTest: Add parameter for custom tasks

Added a parameter, 'tasks', to power_LoadTest's control file that can
override the default tasks in extension/urls.js with a custom set of
tasks.

Also fixed the way URL cycling delays are scaled in background.html.
Previously, they were not scaled along with start and duration, based on
time_ratio.

Also created functions to convert time into milliseconds, to clean
up code.


BUG=chromium-os:13437
TEST=Run the example in the control file.  Set loop_time to something
low, like 120 seconds, and loop_count to 1, so the test doesn't run for
an hour.

Change-Id: I8187341934ceb1944f5c5cdb2ad9ddc64b9169fc
Signed-off-by: Simon Que <sque@chromium.org>;

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7868162

[Sameer Nanda, 2011-03-31 23:42:21]

Looking good for the most part.

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
File client/site_tests/power_LoadTest/control (right):

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/control:43: #       repeat;<comma-delimited
urls>;<duration>;<delay>
"cycle" instead of "repeat" to match up with rest of code?

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/control:47: # followed by task1 for 20 minutes,
for a total of 50 minutes.
lets change the units of duration to seconds instead of minutes

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/control:53: #         
'single;www.wikipedia.org;20'
which of these would be in the foreground, ie, can the order of these tasks be
used to control which window is in the foreground?

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
File client/site_tests/power_LoadTest/extension/background.html (right):

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/extension/background.html:68:
task_strings_global = task_strings;
seems like an unused variable? delete it.

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
File client/site_tests/power_LoadTest/extension/urls.js (right):

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/extension/urls.js:32: delay: seconds(10), // A
minute on each page
this should be seconds(60)
nice cleanup, btw :)

[Simon Que, 2011-04-01 21:37:15]

PTAL

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
File client/site_tests/power_LoadTest/control (right):

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/control:43: #       repeat;<comma-delimited
urls>;<duration>;<delay>
On 2011/03/31 23:42:22, Sameer Nanda wrote:
> "cycle" instead of "repeat" to match up with rest of code?

Done.  Also single -> window.

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/control:47: # followed by task1 for 20 minutes,
for a total of 50 minutes.
On 2011/03/31 23:42:22, Sameer Nanda wrote:
> lets change the units of duration to seconds instead of minutes

Done.

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/control:53: #         
'single;www.wikipedia.org;20'
On 2011/03/31 23:42:22, Sameer Nanda wrote:
> which of these would be in the foreground, ie, can the order of these tasks be
> used to control which window is in the foreground?

No they can't.  They are currently all sequential.  I can change the syntax so
that background / foreground can be done in parallel.  e.g., A1 & A2 + B1 + C1 &
C2:

1. A1 and A2 in parallel
2. B1
3. C1 and C2 in parallel

This can be done in another patch.

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
File client/site_tests/power_LoadTest/extension/background.html (right):

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/extension/background.html:68:
task_strings_global = task_strings;
On 2011/03/31 23:42:22, Sameer Nanda wrote:
> seems like an unused variable? delete it.

Done.

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
File client/site_tests/power_LoadTest/extension/urls.js (right):

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/extension/urls.js:32: delay: seconds(10), // A
minute on each page
On 2011/03/31 23:42:22, Sameer Nanda wrote:
> this should be seconds(60)
> nice cleanup, btw :)

Done.

[Simon Que, 2011-04-01 21:48:33]

http://codereview.chromium.org/6675052/diff/6001/client/site_tests/power_Load...
File client/site_tests/power_LoadTest/extension/background.html (right):

http://codereview.chromium.org/6675052/diff/6001/client/site_tests/power_Load...
client/site_tests/power_LoadTest/extension/background.html:67: var task_strings
= tasks_string.split('+');
Now using '+' instead of '&', which we will save for specifying parallel tasks
in the future.

http://codereview.chromium.org/6675052/diff/6001/client/site_tests/power_Load...
client/site_tests/power_LoadTest/extension/background.html:98: time += duration;
This was a bug.

http://codereview.chromium.org/6675052/diff/6001/client/site_tests/power_Load...
client/site_tests/power_LoadTest/extension/background.html:122: //if (0)
Oops, deleting.

http://codereview.chromium.org/6675052/diff/6001/client/site_tests/power_Load...
client/site_tests/power_LoadTest/extension/background.html:149: if
(cycle.timeout < cycle.delay / time_ratio && cycle.timeout > 0) {
Time ratio should apply to delay as well.

[Sameer Nanda, 2011-04-04 16:39:34]

LGTM. Thanks!

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
File client/site_tests/power_LoadTest/control (right):

http://codereview.chromium.org/6675052/diff/1/client/site_tests/power_LoadTes...
client/site_tests/power_LoadTest/control:53: #         
'single;www.wikipedia.org;20'
On 2011/04/01 21:37:15, Simon Que wrote:
> On 2011/03/31 23:42:22, Sameer Nanda wrote:
> > which of these would be in the foreground, ie, can the order of these tasks
be
> > used to control which window is in the foreground?
> 
> No they can't.  They are currently all sequential.  I can change the syntax so
> that background / foreground can be done in parallel.  e.g., A1 & A2 + B1 + C1
&
> C2:
> 
> 1. A1 and A2 in parallel
> 2. B1
> 3. C1 and C2 in parallel
> 
> This can be done in another patch.
Yes, lets do this in a subsequent patch.