Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 6675043: Fix minor issues in typed array load/store implementation (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 3610 matching lines...) Expand 10 before | Expand all | Expand 10 after
3622 case kExternalPixelArray: 3622 case kExternalPixelArray:
3623 { // Clamp the value to [0..255]. 3623 { // Clamp the value to [0..255].
3624 NearLabel done; 3624 NearLabel done;
3625 __ test(ecx, Immediate(0xFFFFFF00)); 3625 __ test(ecx, Immediate(0xFFFFFF00));
3626 __ j(zero, &done); 3626 __ j(zero, &done);
3627 __ setcc(negative, ecx); // 1 if negative, 0 if positive. 3627 __ setcc(negative, ecx); // 1 if negative, 0 if positive.
3628 __ dec_b(ecx); // 0 if negative, 255 if positive. 3628 __ dec_b(ecx); // 0 if negative, 255 if positive.
3629 __ bind(&done); 3629 __ bind(&done);
3630 } 3630 }
3631 __ mov_b(Operand(edi, ebx, times_1, 0), ecx); 3631 __ mov_b(Operand(edi, ebx, times_1, 0), ecx);
3632 break;
3632 case kExternalByteArray: 3633 case kExternalByteArray:
3633 case kExternalUnsignedByteArray: 3634 case kExternalUnsignedByteArray:
3634 __ mov_b(Operand(edi, ebx, times_1, 0), ecx); 3635 __ mov_b(Operand(edi, ebx, times_1, 0), ecx);
3635 break; 3636 break;
3636 case kExternalShortArray: 3637 case kExternalShortArray:
3637 case kExternalUnsignedShortArray: 3638 case kExternalUnsignedShortArray:
3638 __ mov_w(Operand(edi, ebx, times_2, 0), ecx); 3639 __ mov_w(Operand(edi, ebx, times_2, 0), ecx);
3639 break; 3640 break;
3640 default: 3641 default:
3641 UNREACHABLE(); 3642 UNREACHABLE();
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
3701 3702
3702 return GetCode(flags); 3703 return GetCode(flags);
3703 } 3704 }
3704 3705
3705 3706
3706 #undef __ 3707 #undef __
3707 3708
3708 } } // namespace v8::internal 3709 } } // namespace v8::internal
3709 3710
3710 #endif // V8_TARGET_ARCH_IA32 3711 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698