Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 6675043: Fix minor issues in typed array load/store implementation (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2286 matching lines...) Expand 10 before | Expand all | Expand 10 after
2297 __ movsx_w(result, Operand(external_pointer, key, times_2, 0)); 2297 __ movsx_w(result, Operand(external_pointer, key, times_2, 0));
2298 break; 2298 break;
2299 case kExternalUnsignedShortArray: 2299 case kExternalUnsignedShortArray:
2300 __ movzx_w(result, Operand(external_pointer, key, times_2, 0)); 2300 __ movzx_w(result, Operand(external_pointer, key, times_2, 0));
2301 break; 2301 break;
2302 case kExternalIntArray: 2302 case kExternalIntArray:
2303 __ mov(result, Operand(external_pointer, key, times_4, 0)); 2303 __ mov(result, Operand(external_pointer, key, times_4, 0));
2304 break; 2304 break;
2305 case kExternalUnsignedIntArray: 2305 case kExternalUnsignedIntArray:
2306 __ mov(result, Operand(external_pointer, key, times_4, 0)); 2306 __ mov(result, Operand(external_pointer, key, times_4, 0));
2307 __ test(Operand(result), Immediate(0x80000000)); 2307 __ test(result, Operand(result));
2308 // TODO(danno): we could be more clever here, perhaps having a special 2308 // TODO(danno): we could be more clever here, perhaps having a special
2309 // version of the stub that detects if the overflow case actually 2309 // version of the stub that detects if the overflow case actually
2310 // happens, and generate code that returns a double rather than int. 2310 // happens, and generate code that returns a double rather than int.
2311 DeoptimizeIf(not_zero, instr->environment()); 2311 DeoptimizeIf(negative, instr->environment());
2312 break; 2312 break;
2313 case kExternalFloatArray: 2313 case kExternalFloatArray:
2314 UNREACHABLE(); 2314 UNREACHABLE();
2315 break; 2315 break;
2316 } 2316 }
2317 } 2317 }
2318 } 2318 }
2319 2319
2320 2320
2321 void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) { 2321 void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) {
(...skipping 1781 matching lines...) Expand 10 before | Expand all | Expand 10 after
4103 ASSERT(osr_pc_offset_ == -1); 4103 ASSERT(osr_pc_offset_ == -1);
4104 osr_pc_offset_ = masm()->pc_offset(); 4104 osr_pc_offset_ = masm()->pc_offset();
4105 } 4105 }
4106 4106
4107 4107
4108 #undef __ 4108 #undef __
4109 4109
4110 } } // namespace v8::internal 4110 } } // namespace v8::internal
4111 4111
4112 #endif // V8_TARGET_ARCH_IA32 4112 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698