chrome/browser/extensions/extension_infobar_apitest.cc - Issue 6675033: Fix DCHECK in infobar animation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_infobar_apitest.cc

Issue 6675033: Fix DCHECK in infobar animation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added InvalidateLayout calls to animation and target_height changes. Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/extension_crash_recovery_browsertest.cc ('k') | chrome/browser/ui/views/infobars/extension_infobar.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "chrome/browser/extensions/extension_apitest.h"	6 #include "chrome/browser/extensions/extension_apitest.h"

7 #include "chrome/common/chrome_switches.h"	7 #include "chrome/common/chrome_switches.h"

8	8

9 #if defined(OS_WIN)	9 #if defined(OS_WIN)

10 // Also marking this as disabled on Windows. See http://crbug.com/75451.	10 // Also marking this as disabled on Windows. See http://crbug.com/75451.

11 #define MAYBE_Infobars DISABLED_Infobars	11 #define MAYBE_Infobars Infobars

12 #else	12 #else

13 // Need to finish port to Linux. See http://crbug.com/39916 for details.	13 // Need to finish port to Linux. See http://crbug.com/39916 for details.

14 // Temporarily marked as DISABLED on OSX too. See http://crbug.com/60990 for det ails.	14 // Temporarily marked as DISABLED on OSX too. See http://crbug.com/60990 for det ails.

15 #define MAYBE_Infobars DISABLED_Infobars	15 #define MAYBE_Infobars Infobars

16 #endif	16 #endif

17	17

18 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Infobars) {	18 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Infobars) {

19 // TODO(finnur): Remove once infobars are no longer experimental (bug 39511).	19 // TODO(finnur): Remove once infobars are no longer experimental (bug 39511).

20 CommandLine::ForCurrentProcess()->AppendSwitch(	20 CommandLine::ForCurrentProcess()->AppendSwitch(

21 switches::kEnableExperimentalExtensionApis);	21 switches::kEnableExperimentalExtensionApis);

22	22

23 ASSERT_TRUE(RunExtensionTest("infobars")) << message_;	23 ASSERT_TRUE(RunExtensionTest("infobars")) << message_;

24 }	24 }

OLD	NEW