Issue 6675020: Relanding histogram static removal changes. This is a revert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6675020: Relanding histogram static removal changes. This is a revert (Closed)

Created:
9 years, 9 months ago by ramant (doing other things)

Modified:
9 years, 7 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Relanding histogram static removal changes. This is a revert of http://src.chromium.org/viewvc/chrome?view=rev&revision=78925 The following is the original check-in and review. Removed the static on all histogram macros. If this change sticks, then we could stop using these macros and will change all the code that use histogram macros. BUG=76092 TEST=histogram unit tests and watch out if this change has performance impact. We did a trial run of this patch and we didn't see any impact in performance bots. R=jar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78460 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78966

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	base/metrics/histogram.h	View		10 chunks	+10 lines, -10 lines	0 comments	Download