Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 6675015: Modify au_test_harness and ctest to work from new location. (Closed)

Created:
9 years, 9 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
dgarrett
CC:
chromium-os-reviews_chromium.org, sosa
Visibility:
Public.

Description

Modify au_test_harness and ctest to work from new location. I'm leaving behind symlink in src/scripts/bin for these. I verified that the builder code that calls those symlinks still works correctly with these new paths. This required eliminating all references to __file__. I have also removed dead code from ctest. I verified that this code is no longer used at all. Change-Id: I6fc01129b6381c972976d8d8abcb5ab29f55263d BUG=chromium-os:11172 TEST=Ran both ctest and cros_au_test_harness with x86-mario and x86-generic commands from buildbot scripts. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=18fea3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -52 lines) Patch
M au_test_harness/au_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M au_test_harness/au_worker.py View 1 chunk +2 lines, -2 lines 0 comments Download
A au_test_harness/constants.py View 1 chunk +1 line, -0 lines 0 comments Download
M au_test_harness/cros_au_test_harness.py View 1 chunk +3 lines, -1 line 0 comments Download
A ctest/constants.py View 1 chunk +1 line, -0 lines 0 comments Download
M ctest/ctest.py View 11 chunks +27 lines, -47 lines 0 comments Download
A lib/constants.py View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
9 years, 9 months ago (2011-03-22 00:12:23 UTC) #1
dgarrett
9 years, 9 months ago (2011-03-22 00:44:59 UTC) #2
On 2011/03/22 00:12:23, sosa wrote:

LGTM, except for ctest/constants.py. It looks to me like that file was included
by mistake.

Powered by Google App Engine
This is Rietveld 408576698