Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 6675005: Integrate the new input method API for Views into Chromium. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add some DCHECKs. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/find_bar_view.cc
diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc
index 109cc2cc98396368c20f9c4292d52d7c1e37bb54..d2fb903faef86663d4a27028c9a4c5aeab3fd34b 100644
--- a/chrome/browser/ui/views/find_bar_view.cc
+++ b/chrome/browser/ui/views/find_bar_view.cc
@@ -88,9 +88,6 @@ static const int kDefaultCharWidth = 43;
FindBarView::FindBarView(FindBarHost* host)
: DropdownBarView(host),
-#if defined(OS_LINUX)
- ignore_contents_changed_(false),
-#endif
find_text_(NULL),
match_count_text_(NULL),
focus_forwarder_view_(NULL),
@@ -179,13 +176,7 @@ FindBarView::~FindBarView() {
}
void FindBarView::SetFindText(const string16& find_text) {
-#if defined(OS_LINUX)
- ignore_contents_changed_ = true;
-#endif
find_text_->SetText(find_text);
-#if defined(OS_LINUX)
- ignore_contents_changed_ = false;
-#endif
}
string16 FindBarView::GetFindText() const {
@@ -469,12 +460,6 @@ void FindBarView::ButtonPressed(
void FindBarView::ContentsChanged(views::Textfield* sender,
const string16& new_contents) {
-#if defined(OS_LINUX)
- // On gtk setting the text in the find view causes a notification.
- if (ignore_contents_changed_)
- return;
-#endif
-
FindBarController* controller = find_bar_host()->GetFindBarController();
DCHECK(controller);
// We must guard against a NULL tab_contents, which can happen if the text

Powered by Google App Engine
This is Rietveld 408576698