Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: chrome/browser/chromeos/login/registration_screen.cc

Issue 6675005: Integrate the new input method API for Views into Chromium. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/registration_screen.cc
diff --git a/chrome/browser/chromeos/login/registration_screen.cc b/chrome/browser/chromeos/login/registration_screen.cc
index 3aaf79d3f836b7146cd1e0b89f90b92f2262f58d..08509dc8c52391959bccd91dabb89a2a4d9d00fa 100644
--- a/chrome/browser/chromeos/login/registration_screen.cc
+++ b/chrome/browser/chromeos/login/registration_screen.cc
@@ -123,8 +123,10 @@ void RegistrationScreen::OnPageLoadFailed(const std::string& url) {
void RegistrationScreen::HandleKeyboardEvent(
const NativeWebKeyboardEvent& event) {
views::Widget* widget = view()->GetWidget();
- if (widget && event.os_event && !event.skip_in_browser)
- static_cast<views::WidgetGtk*>(widget)->HandleKeyboardEvent(event.os_event);
+ if (widget && event.os_event && !event.skip_in_browser) {
+ views::KeyEvent views_event(reinterpret_cast<GdkEvent*>(event.os_event));
oshima 2011/03/24 22:58:47 does this have to be reinterpret_cast?
James Su 2011/03/25 05:57:21 I think it has to, though I never tried. GdkEvent
oshima 2011/03/25 17:31:25 I see, os_event is key event. It needs to be reint
+ static_cast<views::WidgetGtk*>(widget)->HandleKeyboardEvent(views_event);
+ }
}
///////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698