tests/scm_unittest.py - Issue 6674059: Make sure warnings fail the check when may_prompt=False. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(18)

My Issues | Starred Open | Closed | All

Unified Diff: tests/scm_unittest.py

Issue 6674059: Make sure warnings fail the check when may_prompt=False. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: moved determine_scm() Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« presubmit_support.py ('K') | « tests/presubmit_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/scm_unittest.py

diff --git a/tests/scm_unittest.py b/tests/scm_unittest.py

index 783fecd3da0eafcacb9f51795ae4b5be9dfc2e0f..1b157e4e72df0988aea1474c9be30d9f9fd3e34a 100755

--- a/tests/scm_unittest.py

+++ b/tests/scm_unittest.py

@@ -39,8 +39,8 @@ class RootTestCase(BaseSCMTestCase):

self.mox.ReplayAll()

members = [

'GetCasedPath', 'GenFakeDiff', 'GIT', 'SVN', 'ValidateEmail',

- 'cStringIO', 'gclient_utils', 'glob', 'logging', 'os', 're', 'shutil',

- 'subprocess', 'sys', 'tempfile', 'time', 'xml',

+ 'cStringIO', 'determine_scm', 'gclient_utils', 'glob', 'logging', 'os',

+ 're', 'shutil', 'subprocess', 'sys', 'tempfile', 'time', 'xml',

]

# If this test fails, you should add the relevant test.

self.compareMembers(scm, members)

« presubmit_support.py ('K') | « tests/presubmit_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698