Make URLRequestHttpJob the only URLRequestJob concerned with FilterContext.

net/url_request/url_request_job.h

Index: net/url_request/url_request_job.h
diff --git a/net/url_request/url_request_job.h b/net/url_request/url_request_job.h
index 3b65f8bfeca0c3874b7d6a9dad0b13834381038a..590d78c7c687173c15c0e9eab465fd9c392ebd5c 100644
--- a/net/url_request/url_request_job.h
+++ b/net/url_request/url_request_job.h
@@ -115,22 +115,13 @@ class URLRequestJob : public base::RefCounted<URLRequestJob>,
   //       useful results once per job.
   virtual bool GetResponseCookies(std::vector<std::string>* cookies);
 
-  // Called to fetch the encoding types for this request. Only makes sense for
-  // some types of requests. Returns true on success. Calling this on a request
-  // that doesn't have or specify an encoding type will return false.
-  // Returns a array of strings showing the sequential encodings used on the
-  // content.
-  // For example, encoding_types[0] = FILTER_TYPE_SDCH and encoding_types[1] =
-  // FILTER_TYPE_GZIP, means the content was first encoded by sdch, and then
-  // result was encoded by gzip.  To decode, a series of filters must be applied
-  // in the reverse order (in the above example, ungzip first, and then sdch
-  // expand).
-  virtual bool GetContentEncodings(
-      std::vector<Filter::FilterType>* encoding_types);
-
-  // Called to setup stream filter for this request. An example of filter is
+  // Called to setup a stream filter for this request. An example of filter is
   // content encoding/decoding.
-  void SetupFilter();
+  // Subclasses should return the appropriate Filter, or NULL for no Filter.
+  // This class takes ownership of the returned Filter.
+  //
+  // The default implementation returns NULL.
+  virtual Filter* SetupFilter();

[willchan no longer on Chromium, 2011/03/16 23:13:17]

Offhand, it looks like this might be able to be a const member function. Is that
right?

[adamk, 2011/03/16 23:21:34]

Sure, let's make that const.  Done.

 
   // Called to determine if this response is a redirect.  Only makes sense
   // for some types of requests.  This method returns true if the response