src/api.cc - Issue 6674034: Fix Array::New(length) in the API to return an array with the provided length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 6674034: Fix Array::New(length) in the API to return an array with the provided length. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address comments. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 9e77d31d17b11ebd258b89ba7a2031a723827007..8a8640d33d28aa6565daaccc5a86b945f94036cd 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -3960,7 +3960,9 @@ Local<v8::Array> v8::Array::New(int length) {

EnsureInitialized("v8::Array::New()");

LOG_API("Array::New");

ENTER_V8;

- i::Handle<i::JSArray> obj = i::Factory::NewJSArray(length);

+ int real_length = length > 0 ? length : 0;

+ i::Handle<i::JSArray> obj = i::Factory::NewJSArray(real_length);

+ obj->set_length(*i::Factory::NewNumberFromInt(real_length));

return Utils::ToLocal(obj);

}

« no previous file with comments | « include/v8.h ('k') | src/factory.h » ('j') | no next file with comments »