Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: presubmit_canned_checks.py

Issue 6674014: Make git-cl work with OWNERS files in a non .git/hooks/pre-cl-* world (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: clean up logging Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« git_cl/git_cl.py ('K') | « git_cl/test/owners.sh ('k') | presubmit_support.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 77827054ee803e8b10b82d5c6f6804cff701a190..40df31a59d60bb2bd9f5006f3cf9641652456f0d 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -634,7 +634,7 @@ def CheckOwners(input_api, output_api, email_regexp=None,
if email_regexp:
owners_db.email_regexp = input_api.re.compile(email_regexp)
- if input_api.is_committing and input_api.is_tbr:
+ if input_api.is_committing and input_api.tbr:
return [output_api.PresubmitNotifyResult(
'--tbr was specified, skipping OWNERS check')]
elif input_api.is_committing:
« git_cl/git_cl.py ('K') | « git_cl/test/owners.sh ('k') | presubmit_support.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698