Issue 6674001: Blacklist pulseaudio and perl to make sure they don't creep in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6674001: Blacklist pulseaudio and perl to make sure they don't creep in. (Closed)

Created:
9 years, 9 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Blacklist pulseaudio and perl to make sure they don't creep in. BUG=chromium-os:12984 TEST=x86-mario build_packages, build_image, mod_image_for_test Change-Id: Ia1fb9c214210c6e58acf25da59f40a7e5ab67d70 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=34c8389 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=61fbb35

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chromeos_blacklist	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

9 years, 9 months ago (2011-03-10 22:07:46 UTC) #2

LGTM

On Thu, Mar 10, 2011 at 2:04 PM,  <petkov@chromium.org> wrote:
> Reviewers: sosa,
>
> Description:
> Blacklist pulseaudio and perl to make sure they don't creep in.
>
> BUG=chromium-os:12984
> TEST=x86-mario build_packages, build_image, mod_image_for_test
>
> Change-Id: Ia1fb9c214210c6e58acf25da59f40a7e5ab67d70
>
> Please review this at http://codereview.chromium.org/6674001/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
>
> Affected files:
>  M chromeos_blacklist
>
>
> Index: chromeos_blacklist
> diff --git a/chromeos_blacklist b/chromeos_blacklist
> index
>
8768a4772811caeaa3197def3036233180ab0c5f..66b7b4925556f8aeb935f59bed36b65069a08764
> 100644
> --- a/chromeos_blacklist
> +++ b/chromeos_blacklist
> @@ -1,5 +1,7 @@
>  app-text/iso-codes
>  dev-java/icedtea
>  dev-java/icedtea6-bin
> +dev-lang/perl
>  dev-lang/python
> +media-sound/pulseaudio
>  x11-libs/libxklavier
>
>
>

Expand Messages | Collapse Messages