Issue 6673098: Remove PPB_Var interface's scripting functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6673098: Remove PPB_Var interface's scripting functionality. (Closed)

Created:
9 years, 9 months ago by neb

Modified:
9 years, 7 months ago

Reviewers:
noelallen_use_chromium, brettw

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove PPB_Var interface's scripting functionality. PPB_Var now only deals with the PPB_Var datatype. PPB_Var_Deprecated provides scripting for legacy users, post message API will be the replacement in the future. BUG=76453 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79139

Patch Set 1 : Fixed tests #

Patch Set 2 : Add tests. #

Patch Set 3 : Removed ConvertType, as per email thread. #

Patch Set 4 : Removing convert. #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1309 lines)			Patch
D	ppapi/c/ppb_class.h	View		1 chunk	+0 lines, -154 lines	0 comments	Download
M	ppapi/c/ppb_var.h	View	1 2	3 chunks	+1 line, -258 lines	0 comments	Download
M	ppapi/ppapi_cpp.gypi	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/ppapi_tests.gypi	View	1 2 3	2 chunks	+0 lines, -4 lines	0 comments	Download
M	ppapi/proxy/ppapi_messages.h	View	1 2	3 chunks	+0 lines, -15 lines	0 comments	Download
M	ppapi/tests/all_c_includes.h	View	1 2	2 chunks	+0 lines, -2 lines	0 comments	Download
M	ppapi/tests/arch_dependent_sizes_32.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ppapi/tests/arch_dependent_sizes_64.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
D	ppapi/tests/test_class.h	View	1	1 chunk	+0 lines, -32 lines	0 comments	Download
D	ppapi/tests/test_class.cc	View	1	1 chunk	+0 lines, -50 lines	0 comments	Download
D	ppapi/tests/test_var.h	View	2 3	1 chunk	+0 lines, -30 lines	0 comments	Download
D	ppapi/tests/test_var.cc	View	2 3	1 chunk	+0 lines, -168 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	1 2	3 chunks	+0 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_object.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/var.cc	View	1 2 3	5 chunks	+1 line, -215 lines	0 comments	Download
D	webkit/plugins/ppapi/var_object_class.h	View		1 chunk	+0 lines, -76 lines	0 comments	Download
D	webkit/plugins/ppapi/var_object_class.cc	View		1 chunk	+0 lines, -290 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages