Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3840)

Unified Diff: chrome/browser/webdata/web_data_service_unittest.cc

Issue 6673079: Reduce boxing and unboxing of AutofillFieldType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/autofill_options_handler.cc ('k') | chrome/browser/webdata/web_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webdata/web_data_service_unittest.cc
diff --git a/chrome/browser/webdata/web_data_service_unittest.cc b/chrome/browser/webdata/web_data_service_unittest.cc
index 90dc9509033d238eea26aede01e7780cb94de9af..86482aa3b0712018e6e7c7001c026a034d6cb892 100644
--- a/chrome/browser/webdata/web_data_service_unittest.cc
+++ b/chrome/browser/webdata/web_data_service_unittest.cc
@@ -322,9 +322,9 @@ TEST_F(WebDataServiceAutofillTest, ProfileRemove) {
TEST_F(WebDataServiceAutofillTest, ProfileUpdate) {
AutofillProfile profile1;
- profile1.SetInfo(AutofillType(NAME_FIRST), ASCIIToUTF16("Abe"));
+ profile1.SetInfo(NAME_FIRST, ASCIIToUTF16("Abe"));
AutofillProfile profile2;
- profile2.SetInfo(AutofillType(NAME_FIRST), ASCIIToUTF16("Alice"));
+ profile2.SetInfo(NAME_FIRST, ASCIIToUTF16("Alice"));
EXPECT_CALL(*observer_helper_->observer(), Observe(_, _, _)).
WillOnce(DoDefault()).
@@ -344,7 +344,7 @@ TEST_F(WebDataServiceAutofillTest, ProfileUpdate) {
STLDeleteElements(&consumer.result());
AutofillProfile profile1_changed(profile1);
- profile1_changed.SetInfo(AutofillType(NAME_FIRST), ASCIIToUTF16("Bill"));
+ profile1_changed.SetInfo(NAME_FIRST, ASCIIToUTF16("Bill"));
const AutofillProfileChange expected_change(
AutofillProfileChange::UPDATE, profile1.guid(), &profile1_changed);
@@ -441,9 +441,9 @@ TEST_F(WebDataServiceAutofillTest, CreditCardRemove) {
TEST_F(WebDataServiceAutofillTest, CreditUpdate) {
CreditCard card1;
- card1.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Abe"));
+ card1.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Abe"));
CreditCard card2;
- card2.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Alice"));
+ card2.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Alice"));
EXPECT_CALL(*observer_helper_->observer(), Observe(_, _, _)).
Times(2).
@@ -464,7 +464,7 @@ TEST_F(WebDataServiceAutofillTest, CreditUpdate) {
STLDeleteElements(&consumer.result());
CreditCard card1_changed(card1);
- card1_changed.SetInfo(AutofillType(CREDIT_CARD_NAME), ASCIIToUTF16("Bill"));
+ card1_changed.SetInfo(CREDIT_CARD_NAME, ASCIIToUTF16("Bill"));
const AutofillCreditCardChange expected_change(
AutofillCreditCardChange::UPDATE, card1.guid(), &card1_changed);
« no previous file with comments | « chrome/browser/ui/webui/options/autofill_options_handler.cc ('k') | chrome/browser/webdata/web_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698