chrome/browser/automation/testing_automation_provider.cc - Issue 6673079: Reduce boxing and unboxing of AutofillFieldType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 6673079: Reduce boxing and unboxing of AutofillFieldType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/select_control_handler_unittest.cc ('k') | chrome/browser/sync/glue/autofill_model_associator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/testing_automation_provider.cc

diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc

index 83f82debe004531e43607ca30935d3667f45be6c..3f44dbf845d378f3d33f5215a9e4a8507018c6d0 100644

--- a/chrome/browser/automation/testing_automation_provider.cc

+++ b/chrome/browser/automation/testing_automation_provider.cc

@@ -4204,7 +4204,7 @@ ListValue* TestingAutomationProvider::GetListFromAutofillProfiles(

for (std::map<AutofillFieldType, std::string>::iterator

type_it = autofill_type_to_string.begin();

type_it != autofill_type_to_string.end(); ++type_it) {

- string16 value = profile->GetFieldText(AutofillType(type_it->first));

+ string16 value = profile->GetFieldText(type_it->first);

if (value.length()) { // If there was something stored for that value.

profile_info->SetString(type_it->second, value);

}

@@ -4232,7 +4232,7 @@ ListValue* TestingAutomationProvider::GetListFromCreditCards(

for (std::map<AutofillFieldType, std::string>::iterator type_it =

credit_card_type_to_string.begin();

type_it != credit_card_type_to_string.end(); ++type_it) {

- string16 value = card->GetFieldText(AutofillType(type_it->first));

+ string16 value = card->GetFieldText(type_it->first);

// If there was something stored for that value.

if (value.length()) {

card_info->SetString(type_it->second, value);

@@ -4265,7 +4265,7 @@ TestingAutomationProvider::GetAutofillProfilesFromList(

if (profile_info->HasKey(type_it->second)) {

if (profile_info->GetString(type_it->second,

&current_value)) {

- profile.SetInfo(AutofillType(type_it->first), current_value);

+ profile.SetInfo(type_it->first, current_value);

} else {

*error_message= "All values must be strings";

break;

@@ -4297,7 +4297,7 @@ std::vector<CreditCard> TestingAutomationProvider::GetCreditCardsFromList(

type_it != credit_card_type_to_string.end(); ++type_it) {

if (card_info->HasKey(type_it->second)) {

if (card_info->GetString(type_it->second, &current_value)) {

- card.SetInfo(AutofillType(type_it->first), current_value);

+ card.SetInfo(type_it->first, current_value);

} else {

*error_message= "All values must be strings";

break;