Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: chrome/browser/autofill/form_group.h

Issue 6673079: Reduce boxing and unboxing of AutofillFieldType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/credit_card.cc ('k') | chrome/browser/autofill/form_group.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/form_group.h
diff --git a/chrome/browser/autofill/form_group.h b/chrome/browser/autofill/form_group.h
index e389ba3cc42bbe11d3e4fdde61d06cbf0c281575..a7517d04e7c4aa49c925fa801681961469ce63cb 100644
--- a/chrome/browser/autofill/form_group.h
+++ b/chrome/browser/autofill/form_group.h
@@ -10,7 +10,6 @@
#include "base/string16.h"
#include "base/string_util.h"
-#include "chrome/browser/autofill/autofill_type.h"
#include "chrome/browser/autofill/field_types.h"
// This class is an interface for collections of form fields, grouped by type.
@@ -32,21 +31,21 @@ class FormGroup {
// Returns the string that should be auto-filled into a text field given the
// type of that field.
- virtual string16 GetFieldText(const AutofillType& type) const = 0;
+ virtual string16 GetFieldText(AutofillFieldType type) const = 0;
// Returns the text for preview.
- virtual string16 GetPreviewText(const AutofillType& type) const;
+ virtual string16 GetPreviewText(AutofillFieldType type) const;
// Used to determine if the text being typed into a field matches the
// information in this FormGroup object. This is used by the preview
// functionality. |matched_text| will be populated with all of the possible
// matches given the type. This method is additive on |matched_text|.
- virtual void FindInfoMatches(const AutofillType& type,
+ virtual void FindInfoMatches(AutofillFieldType type,
const string16& info,
std::vector<string16>* matched_text) const = 0;
// Used to populate this FormGroup object with data.
- virtual void SetInfo(const AutofillType& type, const string16& value) = 0;
+ virtual void SetInfo(AutofillFieldType type, const string16& value) = 0;
// Returns the label for this FormGroup item. This should be overridden for
// form group items that implement a label.
« no previous file with comments | « chrome/browser/autofill/credit_card.cc ('k') | chrome/browser/autofill/form_group.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698