Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2163)

Unified Diff: chrome/browser/autofill/contact_info.h

Issue 6673079: Reduce boxing and unboxing of AutofillFieldType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_profile_unittest.cc ('k') | chrome/browser/autofill/contact_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/contact_info.h
diff --git a/chrome/browser/autofill/contact_info.h b/chrome/browser/autofill/contact_info.h
index 22c618a6e5491e13b881d3a345280a8a294f1797..beb05e69e316e1f4030d5d64fde04bb3e2995ec9 100644
--- a/chrome/browser/autofill/contact_info.h
+++ b/chrome/browser/autofill/contact_info.h
@@ -25,11 +25,11 @@ class NameInfo : public FormGroup {
virtual void GetPossibleFieldTypes(const string16& text,
FieldTypeSet* possible_types) const;
virtual void GetAvailableFieldTypes(FieldTypeSet* available_types) const;
- virtual void FindInfoMatches(const AutofillType& type,
+ virtual void FindInfoMatches(AutofillFieldType type,
const string16& info,
std::vector<string16>* matched_text) const;
- virtual string16 GetFieldText(const AutofillType& type) const;
- virtual void SetInfo(const AutofillType& type, const string16& value);
+ virtual string16 GetFieldText(AutofillFieldType type) const;
+ virtual void SetInfo(AutofillFieldType type, const string16& value);
private:
FRIEND_TEST_ALL_PREFIXES(NameInfoTest, TestSetFullName);
@@ -48,7 +48,7 @@ class NameInfo : public FormGroup {
// A helper function for FindInfoMatches that only handles matching the info
// with the requested field type.
- bool FindInfoMatchesHelper(const AutofillFieldType& field_type,
+ bool FindInfoMatchesHelper(AutofillFieldType field_type,
const string16& info,
string16* matched_text) const;
@@ -114,11 +114,11 @@ class EmailInfo : public FormGroup {
virtual void GetPossibleFieldTypes(const string16& text,
FieldTypeSet* possible_types) const;
virtual void GetAvailableFieldTypes(FieldTypeSet* available_types) const;
- virtual void FindInfoMatches(const AutofillType& type,
+ virtual void FindInfoMatches(AutofillFieldType type,
const string16& info,
std::vector<string16>* matched_text) const;
- virtual string16 GetFieldText(const AutofillType& type) const;
- virtual void SetInfo(const AutofillType& type, const string16& value);
+ virtual string16 GetFieldText(AutofillFieldType type) const;
+ virtual void SetInfo(AutofillFieldType type, const string16& value);
private:
string16 email_;
@@ -136,11 +136,11 @@ class CompanyInfo : public FormGroup {
virtual void GetPossibleFieldTypes(const string16& text,
FieldTypeSet* possible_types) const;
virtual void GetAvailableFieldTypes(FieldTypeSet* available_types) const;
- virtual void FindInfoMatches(const AutofillType& type,
+ virtual void FindInfoMatches(AutofillFieldType type,
const string16& info,
std::vector<string16>* matched_text) const;
- virtual string16 GetFieldText(const AutofillType& type) const;
- virtual void SetInfo(const AutofillType& type, const string16& value);
+ virtual string16 GetFieldText(AutofillFieldType type) const;
+ virtual void SetInfo(AutofillFieldType type, const string16& value);
private:
string16 company_name_;
« no previous file with comments | « chrome/browser/autofill/autofill_profile_unittest.cc ('k') | chrome/browser/autofill/contact_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698