Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: chrome/browser/autofill/autofill_manager_unittest.cc

Issue 6673079: Reduce boxing and unboxing of AutofillFieldType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_manager.cc ('k') | chrome/browser/autofill/autofill_merge_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager_unittest.cc
diff --git a/chrome/browser/autofill/autofill_manager_unittest.cc b/chrome/browser/autofill/autofill_manager_unittest.cc
index 3ec6a51dbe5bddfbe5fedc393b6d560967b38e38..eaf6321740f4e6da8778632fa5161775399589ed 100644
--- a/chrome/browser/autofill/autofill_manager_unittest.cc
+++ b/chrome/browser/autofill/autofill_manager_unittest.cc
@@ -1672,14 +1672,13 @@ TEST_F(AutofillManagerTest, FillPhoneNumber) {
AutofillProfile *work_profile = autofill_manager_->GetProfileWithGUID(
"00000000-0000-0000-0000-000000000002");
ASSERT_TRUE(work_profile != NULL);
- const AutofillType phone_type(PHONE_HOME_NUMBER);
- string16 saved_phone = work_profile->GetFieldText(phone_type);
+ string16 saved_phone = work_profile->GetFieldText(PHONE_HOME_NUMBER);
char test_data[] = "1234567890123456";
for (int i = arraysize(test_data) - 1; i >= 0; --i) {
test_data[i] = 0;
SCOPED_TRACE(StringPrintf("Testing phone: %s", test_data));
- work_profile->SetInfo(phone_type, ASCIIToUTF16(test_data));
+ work_profile->SetInfo(PHONE_HOME_NUMBER, ASCIIToUTF16(test_data));
// The page ID sent to the AutofillManager from the RenderView, used to send
// an IPC message back to the renderer.
int page_id = 100 - i;
@@ -1700,7 +1699,7 @@ TEST_F(AutofillManagerTest, FillPhoneNumber) {
}
}
- work_profile->SetInfo(phone_type, saved_phone);
+ work_profile->SetInfo(PHONE_HOME_NUMBER, saved_phone);
}
// Test that we can still fill a form when a field has been removed from it.
« no previous file with comments | « chrome/browser/autofill/autofill_manager.cc ('k') | chrome/browser/autofill/autofill_merge_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698