Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/browser/autofill/autofill_manager.h

Issue 6673079: Reduce boxing and unboxing of AutofillFieldType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile on Windows. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_manager.h
diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h
index cf69c3d1036f39839aa33a99ab69403f4da9be52..24f9c1f48505ff8ce8c129bfb50029c16cfbf8a4 100644
--- a/chrome/browser/autofill/autofill_manager.h
+++ b/chrome/browser/autofill/autofill_manager.h
@@ -140,7 +140,7 @@ class AutofillManager : public TabContentsObserver,
// is filled with the Profile label.
void GetProfileSuggestions(FormStructure* form,
const webkit_glue::FormField& field,
- AutofillType type,
+ AutofillFieldType type,
std::vector<string16>* values,
std::vector<string16>* labels,
std::vector<string16>* icons,
@@ -150,7 +150,7 @@ class AutofillManager : public TabContentsObserver,
// the value of |field| and returns the labels of the matching credit cards.
void GetCreditCardSuggestions(FormStructure* form,
const webkit_glue::FormField& field,
- AutofillType type,
+ AutofillFieldType type,
std::vector<string16>* values,
std::vector<string16>* labels,
std::vector<string16>* icons,
@@ -159,18 +159,18 @@ class AutofillManager : public TabContentsObserver,
// Set |field| argument's value based on |type| and contents of the
// |credit_card|.
void FillCreditCardFormField(const CreditCard* credit_card,
- AutofillType type,
+ AutofillFieldType type,
webkit_glue::FormField* field);
// Set |field| argument's value based on |type| and contents of the |profile|.
void FillFormField(const AutofillProfile* profile,
- AutofillType type,
+ AutofillFieldType type,
webkit_glue::FormField* field);
// Set |field| argument's value for phone/fax number based on contents of the
// |profile|. |type| is the type of the phone.
void FillPhoneNumberField(const AutofillProfile* profile,
- AutofillType type,
+ AutofillFieldType type,
webkit_glue::FormField* field);
// Parses the forms using heuristic matching and querying the Autofill server.

Powered by Google App Engine
This is Rietveld 408576698