Reduce boxing and unboxing of AutofillFieldType

chrome/browser/sync/glue/autofill_model_associator.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/autofill_model_associator.h"
 
 #include <functional>
 #include <vector>
 
 #include "base/string_number_conversions.h"
@@ skipping 225 matching lines @@
   bool autofill_profile_not_migrated = HasNotMigratedYet(write_trans);
 
   if (VLOG_IS_ON(2) && autofill_profile_not_migrated) {
     VLOG(2) << "[AUTOFILL MIGRATION]"
             << "Printing profiles from web db";
 
     for (std::vector<AutofillProfile*>::const_iterator ix =
         all_profiles_from_db.begin(); ix != all_profiles_from_db.end(); ++ix) {
       AutofillProfile* p = *ix;
       VLOG(2) << "[AUTOFILL MIGRATION]  "
-              << p->GetFieldText(AutofillType(NAME_FIRST))
-              << p->GetFieldText(AutofillType(NAME_LAST));
+              << p->GetFieldText(NAME_FIRST)
+              << p->GetFieldText(NAME_LAST);
     }
   }
 
   if (autofill_profile_not_migrated) {
     VLOG(1) << "[AUTOFILL MIGRATION]"
             << "Iterating over sync db";
   }
 
   int64 sync_child_id = autofill_root.GetFirstChildId();
   while (sync_child_id != sync_api::kInvalidId) {
@@ skipping 233 matching lines @@
                            timestamp_union.begin(),
                            timestamp_union.end());
   }
   return different;
 }
 
 // Helper to compare the local value and cloud value of a field, merge into
 // the local value if they differ, and return whether the merge happened.
 bool MergeField(FormGroup* f, AutofillFieldType t,
                 const std::string& specifics_field) {
-  if (UTF16ToUTF8(f->GetFieldText(AutofillType(t))) == specifics_field)
+  if (UTF16ToUTF8(f->GetFieldText(t)) == specifics_field)
     return false;
-  f->SetInfo(AutofillType(t), UTF8ToUTF16(specifics_field));
+  f->SetInfo(t, UTF8ToUTF16(specifics_field));
   return true;
 }
 
 // static
 bool AutofillModelAssociator::FillProfileWithServerData(
     AutofillProfile* merge_into,
     const sync_pb::AutofillProfileSpecifics& specifics) {
   bool diff = false;
   AutofillProfile* p = merge_into;
   const sync_pb::AutofillProfileSpecifics& s(specifics);
@@ skipping 55 matching lines @@
       sync_service_->SetAutofillMigrationState(syncable::MIGRATED);
 
       VLOG(1) << "[AUTOFILL MIGRATION]"
               << "Current autofill migration state is migrated.";
   }
 
   return false;
 }
 
 }  // namespace browser_sync