Reduce boxing and unboxing of AutofillFieldType

chrome/browser/autofill/select_control_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/select_control_handler.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 181 matching lines @@
       SetSelectControlValue(ASCIIToUTF16(kMonthsFull[index]), field) ||
       SetSelectControlValue(ASCIIToUTF16(kMonthsNumeric[index]), field);
   return filled;
 }
 
 }  // namespace
 
 namespace autofill {
 
 void FillSelectControl(const FormGroup& form_group,
-                       AutofillType type,
+                       AutofillFieldType type,
                        webkit_glue::FormField* field) {
   DCHECK(field);
   DCHECK_EQ(ASCIIToUTF16("select-one"), field->form_control_type);
 
   string16 field_text = form_group.GetFieldText(type);
   if (field_text.empty())
     return;
 
   string16 value;
   for (size_t i = 0; i < field->option_strings.size(); ++i) {
     if (field_text == field->option_strings[i]) {
       // An exact match, use it.
       value = field_text;
       break;
     }
 
     if (StringToLowerASCII(field->option_strings[i]) ==
         StringToLowerASCII(field_text)) {
       // A match, but not in the same case. Save it in case an exact match is
       // not found.
       value = field->option_strings[i];
     }
   }
 
   if (!value.empty()) {
     field->value = value;
     return;
   }
 
-  if (type.field_type() == ADDRESS_HOME_STATE ||
-      type.field_type() == ADDRESS_BILLING_STATE) {
+  if (type == ADDRESS_HOME_STATE || type == ADDRESS_BILLING_STATE)
     FillStateSelectControl(field_text, field);
-  } else if (type.field_type() == ADDRESS_HOME_COUNTRY ||
-             type.field_type() == ADDRESS_BILLING_COUNTRY) {
+  else if (type == ADDRESS_HOME_COUNTRY || type == ADDRESS_BILLING_COUNTRY)
     FillCountrySelectControl(form_group, field);
-  } else if (type.field_type() == CREDIT_CARD_EXP_MONTH) {
+  else if (type == CREDIT_CARD_EXP_MONTH)
     FillExpirationMonthSelectControl(field_text, field);
-  }
 
   return;
 }
 
 }  // namespace autofill