Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: chrome/browser/autofill/autofill_field.cc

Issue 6673079: Reduce boxing and unboxing of AutofillFieldType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autofill/autofill_field.h" 5 #include "chrome/browser/autofill/autofill_field.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/sha1.h" 8 #include "base/sha1.h"
9 #include "base/string_number_conversions.h" 9 #include "base/string_number_conversions.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 22 matching lines...) Expand all
33 AutofillField::AutofillField(const webkit_glue::FormField& field, 33 AutofillField::AutofillField(const webkit_glue::FormField& field,
34 const string16& unique_name) 34 const string16& unique_name)
35 : webkit_glue::FormField(field), 35 : webkit_glue::FormField(field),
36 unique_name_(unique_name), 36 unique_name_(unique_name),
37 server_type_(NO_SERVER_DATA), 37 server_type_(NO_SERVER_DATA),
38 heuristic_type_(UNKNOWN_TYPE) { 38 heuristic_type_(UNKNOWN_TYPE) {
39 } 39 }
40 40
41 AutofillField::~AutofillField() {} 41 AutofillField::~AutofillField() {}
42 42
43 void AutofillField::set_heuristic_type(const AutofillFieldType& type) { 43 void AutofillField::set_heuristic_type(AutofillFieldType type) {
44 if (type >= 0 && type < MAX_VALID_FIELD_TYPE) { 44 if (type >= 0 && type < MAX_VALID_FIELD_TYPE) {
45 heuristic_type_ = type; 45 heuristic_type_ = type;
46 } else { 46 } else {
47 NOTREACHED(); 47 NOTREACHED();
48 // This case should not be reachable; but since this has potential 48 // This case should not be reachable; but since this has potential
49 // implications on data uploaded to the server, better safe than sorry. 49 // implications on data uploaded to the server, better safe than sorry.
50 heuristic_type_ = UNKNOWN_TYPE; 50 heuristic_type_ = UNKNOWN_TYPE;
51 } 51 }
52 } 52 }
53 53
(...skipping 11 matching lines...) Expand all
65 std::string AutofillField::FieldSignature() const { 65 std::string AutofillField::FieldSignature() const {
66 std::string field_name = UTF16ToUTF8(name); 66 std::string field_name = UTF16ToUTF8(name);
67 std::string type = UTF16ToUTF8(form_control_type); 67 std::string type = UTF16ToUTF8(form_control_type);
68 std::string field_string = field_name + "&" + type; 68 std::string field_string = field_name + "&" + type;
69 return Hash32Bit(field_string); 69 return Hash32Bit(field_string);
70 } 70 }
71 71
72 bool AutofillField::IsFieldFillable() const { 72 bool AutofillField::IsFieldFillable() const {
73 return type() != UNKNOWN_TYPE; 73 return type() != UNKNOWN_TYPE;
74 } 74 }
OLDNEW
« no previous file with comments | « chrome/browser/autofill/autofill_field.h ('k') | chrome/browser/autofill/autofill_ie_toolbar_import_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698