chrome/browser/sync/glue/autofill_profile_model_associator_unittest.cc - Issue 6673079: Reduce boxing and unboxing of AutofillFieldType

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sync/glue/autofill_profile_model_associator_unittest.cc

Issue 6673079: Reduce boxing and unboxing of AutofillFieldType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Compile on Windows. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/sync/glue/autofill_profile_change_processor.cc ('K') | « chrome/browser/sync/glue/autofill_profile_model_associator.cc ('k') | chrome/browser/ui/views/autofill_profiles_view_win.cc » ('j') | chrome/browser/ui/views/autofill_profiles_view_win.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/utf_string_conversions.h"	5 #include "base/utf_string_conversions.h"

6 #include "chrome/browser/sync/engine/read_node_mock.h"	6 #include "chrome/browser/sync/engine/read_node_mock.h"

7 #include "chrome/browser/sync/engine/syncapi_mock.h"	7 #include "chrome/browser/sync/engine/syncapi_mock.h"

8 #include "chrome/browser/sync/glue/autofill_profile_model_associator.h"	8 #include "chrome/browser/sync/glue/autofill_profile_model_associator.h"

9 #include "chrome/browser/sync/syncable/syncable.h"	9 #include "chrome/browser/sync/syncable/syncable.h"

10 #include "chrome/browser/sync/syncable/syncable_mock.h"	10 #include "chrome/browser/sync/syncable/syncable_mock.h"

(...skipping 236 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
247	247

248 EXPECT_CALL(associator_,	248 EXPECT_CALL(associator_,

249 Associate(Pointee(guid), 1));	249 Associate(Pointee(guid), 1));

250	250

251 associator_.AddNativeProfileIfNeededWrapper(	251 associator_.AddNativeProfileIfNeededWrapper(

252 profile_specifics,	252 profile_specifics,

253 &bundle,	253 &bundle,

254 read_node);	254 read_node);

255	255

256 EXPECT_EQ(bundle.new_profiles.size(), (unsigned int)1);	256 EXPECT_EQ(bundle.new_profiles.size(), (unsigned int)1);

257 EXPECT_EQ(	257 EXPECT_EQ(
	dhollowa 2011/03/16 17:07:11 nit: should be able to pull up to the "(" now. nit: should be able to pull up to the "(" now. Ilya Sherman 2011/03/17 03:42:29 Done. Show quoted text On 2011/03/16 17:07:11, dhollowa wrote: > nit: should be able to pull up to the "(" now. Done.
258 bundle.new_profiles.front()->GetFieldText(AutofillType(NAME_FIRST)),	258 bundle.new_profiles.front()->GetFieldText(NAME_FIRST),

259 UTF8ToUTF16(first_name));	259 UTF8ToUTF16(first_name));

260 }	260 }

261	261

OLD	NEW