Reduce boxing and unboxing of AutofillFieldType

chrome/browser/automation/testing_automation_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/testing_automation_provider.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 4184 matching lines @@
   // For each AutofillProfile, transform it to a dictionary object to return.
   for (std::vector<AutofillProfile*>::const_iterator it =
            autofill_profiles.begin();
        it != autofill_profiles.end(); ++it) {
     AutofillProfile* profile = *it;
     DictionaryValue* profile_info = new DictionaryValue;
     // For each of the types, if it has a value, add it to the dictionary.
     for (std::map<AutofillFieldType, std::string>::iterator
          type_it = autofill_type_to_string.begin();
          type_it != autofill_type_to_string.end(); ++type_it) {
-      string16 value = profile->GetFieldText(AutofillType(type_it->first));
+      string16 value = profile->GetFieldText(type_it->first);
       if (value.length()) {  // If there was something stored for that value.
         profile_info->SetString(type_it->second, value);
       }
     }
     profiles->Append(profile_info);
   }
   return profiles;
 }
 
 /* static */
 ListValue* TestingAutomationProvider::GetListFromCreditCards(
     const std::vector<CreditCard*>& credit_cards) {
   ListValue* cards = new ListValue;
 
   std::map<AutofillFieldType, std::string> credit_card_type_to_string =
       GetCreditCardFieldToStringMap();
 
   // For each AutofillProfile, transform it to a dictionary object to return.
   for (std::vector<CreditCard*>::const_iterator it =
            credit_cards.begin();
        it != credit_cards.end(); ++it) {
     CreditCard* card = *it;
     DictionaryValue* card_info = new DictionaryValue;
     // For each of the types, if it has a value, add it to the dictionary.
     for (std::map<AutofillFieldType, std::string>::iterator type_it =
         credit_card_type_to_string.begin();
         type_it != credit_card_type_to_string.end(); ++type_it) {
-      string16 value = card->GetFieldText(AutofillType(type_it->first));
+      string16 value = card->GetFieldText(type_it->first);
       // If there was something stored for that value.
       if (value.length()) {
         card_info->SetString(type_it->second, value);
       }
     }
     cards->Append(card_info);
   }
   return cards;
 }
 
@@ skipping 12 matching lines @@
   for (int i = 0; i < num_profiles; i++) {
     profiles.GetDictionary(i, &profile_info);
     AutofillProfile profile;
     // Loop through the possible profile types and add those provided.
     for (std::map<AutofillFieldType, std::string>::iterator type_it =
          autofill_type_to_string.begin();
          type_it != autofill_type_to_string.end(); ++type_it) {
       if (profile_info->HasKey(type_it->second)) {
         if (profile_info->GetString(type_it->second,
                                     &current_value)) {
-          profile.SetInfo(AutofillType(type_it->first), current_value);
+          profile.SetInfo(type_it->first, current_value);
         } else {
           *error_message= "All values must be strings";
           break;
         }
       }
     }
     autofill_profiles.push_back(profile);
   }
   return autofill_profiles;
 }
@@ skipping 11 matching lines @@
   int num_credit_cards = cards.GetSize();
   for (int i = 0; i < num_credit_cards; i++) {
     cards.GetDictionary(i, &card_info);
     CreditCard card;
     // Loop through the possible credit card fields and add those provided.
     for (std::map<AutofillFieldType, std::string>::iterator type_it =
         credit_card_type_to_string.begin();
         type_it != credit_card_type_to_string.end(); ++type_it) {
       if (card_info->HasKey(type_it->second)) {
         if (card_info->GetString(type_it->second, &current_value)) {
-          card.SetInfo(AutofillType(type_it->first), current_value);
+          card.SetInfo(type_it->first, current_value);
         } else {
           *error_message= "All values must be strings";
           break;
         }
       }
     }
     credit_cards.push_back(card);
   }
   return credit_cards;
 }
@@ skipping 887 matching lines @@
     // If you change this, update Observer for NotificationType::SESSION_END
     // below.
     MessageLoop::current()->PostTask(FROM_HERE,
         NewRunnableMethod(this, &TestingAutomationProvider::OnRemoveProvider));
   }
 }
 
 void TestingAutomationProvider::OnRemoveProvider() {
   AutomationProviderList::GetInstance()->RemoveProvider(this);
 }