Reduce boxing and unboxing of AutofillFieldType

chrome/browser/autofill/phone_number.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/phone_number.h"
 
 #include "base/basictypes.h"
 #include "base/string_util.h"
 #include "chrome/browser/autofill/autofill_profile.h"
 #include "chrome/browser/autofill/autofill_type.h"
@@ skipping 74 matching lines @@
   if (!country_code().empty())
     available_types->insert(GetCountryCodeType());
 
   if (!CityAndNumber().empty())
     available_types->insert(GetCityAndNumberType());
 
   if (!WholeNumber().empty())
     available_types->insert(GetWholeNumberType());
 }
 
-string16 PhoneNumber::GetFieldText(const AutofillType& type) const {
-  AutofillFieldType field_type = type.field_type();
-  if (field_type == GetNumberType())
+string16 PhoneNumber::GetFieldText(AutofillFieldType type) const {
+  if (type == GetNumberType())
     return number();
 
-  if (field_type == GetCityCodeType())
+  if (type == GetCityCodeType())
     return city_code();
 
-  if (field_type == GetCountryCodeType())
+  if (type == GetCountryCodeType())
     return country_code();
 
-  if (field_type == GetCityAndNumberType())
+  if (type == GetCityAndNumberType())
     return CityAndNumber();
 
-  if (field_type == GetWholeNumberType())
+  if (type == GetWholeNumberType())
     return WholeNumber();
 
   return string16();
 }
 
-void PhoneNumber::FindInfoMatches(const AutofillType& type,
+void PhoneNumber::FindInfoMatches(AutofillFieldType type,
                                   const string16& info,
                                   std::vector<string16>* matched_text) const {
   if (matched_text == NULL) {
     DLOG(ERROR) << "NULL matched vector passed in";
     return;
   }
 
   string16 number(info);
   StripPunctuation(&number);
   if (!Validate(number))
     return;
 
   string16 match;
-  if (type.field_type() == UNKNOWN_TYPE) {
+  if (type == UNKNOWN_TYPE) {
     for (int i = 0; i < kAutoFillPhoneLength; ++i) {
       if (FindInfoMatchesHelper(kAutoFillPhoneTypes[i], info, &match))
         matched_text->push_back(match);
     }
   } else {
-    if (FindInfoMatchesHelper(type.subgroup(), info, &match))
+    if (FindInfoMatchesHelper(AutofillType(type).subgroup(), info, &match))
       matched_text->push_back(match);
   }
 }
 
-void PhoneNumber::SetInfo(const AutofillType& type, const string16& value) {
+void PhoneNumber::SetInfo(AutofillFieldType type, const string16& value) {
   string16 number(value);
   StripPunctuation(&number);
   if (!Validate(number))
     return;
 
-  FieldTypeSubGroup subgroup = type.subgroup();
+  FieldTypeSubGroup subgroup = AutofillType(type).subgroup();
   if (subgroup == AutofillType::PHONE_NUMBER)
     set_number(number);
   else if (subgroup == AutofillType::PHONE_CITY_CODE)
     set_city_code(number);
   else if (subgroup == AutofillType::PHONE_COUNTRY_CODE)
     set_country_code(number);
   else if (subgroup == AutofillType::PHONE_CITY_AND_NUMBER ||
            subgroup == AutofillType::PHONE_WHOLE_NUMBER)
     set_whole_number(number);
   else
@@ skipping 141 matching lines @@
       return false;
   }
 
   return true;
 }
 
 // Static.
 void PhoneNumber::StripPunctuation(string16* number) {
   RemoveChars(*number, kPhoneNumberSeparators, number);
 }