Reduce boxing and unboxing of AutofillFieldType

chrome/browser/autofill/contact_info.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_CONTACT_INFO_H_
 #define CHROME_BROWSER_AUTOFILL_CONTACT_INFO_H_
 #pragma once
 
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "base/string16.h"
 #include "chrome/browser/autofill/form_group.h"
 
 // A form group that stores name information.
 class NameInfo : public FormGroup {
  public:
   NameInfo();
   explicit NameInfo(const NameInfo& info);
   virtual ~NameInfo();
 
   NameInfo& operator=(const NameInfo& info);
 
   // FormGroup:
   virtual void GetPossibleFieldTypes(const string16& text,
                                      FieldTypeSet* possible_types) const;
   virtual void GetAvailableFieldTypes(FieldTypeSet* available_types) const;
-  virtual void FindInfoMatches(const AutofillType& type,
+  virtual void FindInfoMatches(AutofillFieldType type,
                                const string16& info,
                                std::vector<string16>* matched_text) const;
-  virtual string16 GetFieldText(const AutofillType& type) const;
-  virtual void SetInfo(const AutofillType& type, const string16& value);
+  virtual string16 GetFieldText(AutofillFieldType type) const;
+  virtual void SetInfo(AutofillFieldType type, const string16& value);
 
  private:
   FRIEND_TEST_ALL_PREFIXES(NameInfoTest, TestSetFullName);
 
   // Returns the full name, which can include up to the first, middle, and last
   // name.
   string16 FullName() const;
 
   // Returns the middle initial if |middle_| is non-empty.  Returns an empty
   // string otherwise.
   string16 MiddleInitial() const;
 
   const string16& first() const { return first_; }
   const string16& middle() const { return middle_; }
   const string16& last() const { return last_; }
 
   // A helper function for FindInfoMatches that only handles matching the info
   // with the requested field type.
-  bool FindInfoMatchesHelper(const AutofillFieldType& field_type,
+  bool FindInfoMatchesHelper(AutofillFieldType field_type,
                              const string16& info,
                              string16* matched_text) const;
 
   // Returns true if |text| is the first name.
   bool IsFirstName(const string16& text) const;
 
   // Returns true if |text| is the middle name.
   bool IsMiddleName(const string16& text) const;
 
   // Returns true if |text| is the last name.
@@ skipping 45 matching lines @@
   EmailInfo();
   explicit EmailInfo(const EmailInfo& info);
   virtual ~EmailInfo();
 
   EmailInfo& operator=(const EmailInfo& info);
 
   // FormGroup:
   virtual void GetPossibleFieldTypes(const string16& text,
                                      FieldTypeSet* possible_types) const;
   virtual void GetAvailableFieldTypes(FieldTypeSet* available_types) const;
-  virtual void FindInfoMatches(const AutofillType& type,
+  virtual void FindInfoMatches(AutofillFieldType type,
                                const string16& info,
                                std::vector<string16>* matched_text) const;
-  virtual string16 GetFieldText(const AutofillType& type) const;
-  virtual void SetInfo(const AutofillType& type, const string16& value);
+  virtual string16 GetFieldText(AutofillFieldType type) const;
+  virtual void SetInfo(AutofillFieldType type, const string16& value);
 
  private:
   string16 email_;
 };
 
 class CompanyInfo : public FormGroup {
  public:
   CompanyInfo();
   explicit CompanyInfo(const CompanyInfo& info);
   virtual ~CompanyInfo();
 
   CompanyInfo& operator=(const CompanyInfo& info);
 
   // FormGroup:
   virtual void GetPossibleFieldTypes(const string16& text,
                                      FieldTypeSet* possible_types) const;
   virtual void GetAvailableFieldTypes(FieldTypeSet* available_types) const;
-  virtual void FindInfoMatches(const AutofillType& type,
+  virtual void FindInfoMatches(AutofillFieldType type,
                                const string16& info,
                                std::vector<string16>* matched_text) const;
-  virtual string16 GetFieldText(const AutofillType& type) const;
-  virtual void SetInfo(const AutofillType& type, const string16& value);
+  virtual string16 GetFieldText(AutofillFieldType type) const;
+  virtual void SetInfo(AutofillFieldType type, const string16& value);
 
  private:
   string16 company_name_;
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_CONTACT_INFO_H_