Issue 6673042: Do not set value on host objects in Object.defineProperty (fixes issue 1250)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6673042: Do not set value on host objects in Object.defineProperty (fixes issue 1250).... (Closed)

Created:
9 years, 9 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Do not set value on host objects in Object.defineProperty (fixes issue 1250). To be compatible with safari we should not change the value on API objects in Object.defineProperty (e.g., the window.location object). Committed: http://code.google.com/p/v8/source/detail?r=7169

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -0 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1	2 chunks	+19 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

The change itself looks fine. Please add a test case. :)

9 years, 9 months ago (2011-03-15 08:35:56 UTC) #2

Mads Ager (chromium)

9 years, 9 months ago (2011-03-15 09:12:50 UTC) #4

LGTM

http://codereview.chromium.org/6673042/diff/2002/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/6673042/diff/2002/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:5717: v8::Handle<Value> value;
Add comment here saying something like: We follow Safari in ignoring assignments
to host object accessors.

Expand Messages | Collapse Messages