Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 6673030: Fixed up incorrect push (Closed)

Created:
9 years, 9 months ago by sjg
Modified:
9 years, 7 months ago
Reviewers:
dhendrix, sosa
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Fixed up incorrect push Somehow I pushed the wrong patch of issue 6508007. This should patch patch set 5 correctly. TBR=sjg (build break) TEST=chromite/buildbot/cbuildbot --buildnumber=3992 --buildroot=/b/cbuild --revisionfile=chromite/buildbot/revisions.pfq x86-generic-pre-flight-queue Check it gets past the init phase. Change-Id: I3f3f83fec36271a36aa1295a129782861196c0c5 BUG= Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6b069ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M lib/cros_build_lib.py View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sjg
Fix for build break
9 years, 9 months ago (2011-03-15 00:22:09 UTC) #1
sosa
LGTM
9 years, 9 months ago (2011-03-15 00:23:31 UTC) #2
dhendrix
On 2011/03/15 00:22:09, sjg wrote: > Fix for build break LGTM
9 years, 9 months ago (2011-03-15 00:23:45 UTC) #3
sjg
9 years, 9 months ago (2011-03-15 00:28:36 UTC) #4
Thanks, sorry for trouble. Wanted to get that change in before I went
off duty :-)

On Mon, Mar 14, 2011 at 5:23 PM,  <dhendrix@chromium.org> wrote:
> On 2011/03/15 00:22:09, sjg wrote:
>>
>> Fix for build break
>
> LGTM
>
> http://codereview.chromium.org/6673030/
>

Powered by Google App Engine
This is Rietveld 408576698