Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 6673003: Move GPU messages to content. I've also switched the IPC structs to use the ... (Closed)

Created:
9 years, 9 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, Paweł Hajdan Jr., apatrick_chromium, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move GPU messages to content. I've also switched the IPC structs to use the new IPC macros that generate serialization code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77721

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -1554 lines) Patch
M chrome/browser/gpu_data_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/gpu_process_host_ui_shim.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gpu_process_host_ui_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/automation_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/automation_messages_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process_logging_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/common_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/common_param_traits.h View 4 chunks +0 lines, -63 lines 0 comments Download
M chrome/common/common_param_traits.cc View 2 chunks +0 lines, -68 lines 0 comments Download
D chrome/common/dx_diag_node.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/common/dx_diag_node.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/gpu_create_command_buffer_config.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/common/gpu_create_command_buffer_config.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/common/gpu_info.h View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/common/gpu_info.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/common/gpu_info_unittest.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/common/gpu_messages.h View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/common/gpu_messages.cc View 1 chunk +0 lines, -249 lines 0 comments Download
D chrome/common/gpu_messages_internal.h View 1 chunk +0 lines, -381 lines 0 comments Download
D chrome/common/gpu_messages_unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/common/gpu_param_traits.h View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/common/gpu_video_common.h View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/common/gpu_video_common.cc View 1 chunk +0 lines, -181 lines 0 comments Download
M chrome/common/render_messages.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/render_messages_internal.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/gpu/gpu_channel.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/gpu/gpu_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/gpu/gpu_command_buffer_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/gpu/gpu_info_collector.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/gpu/gpu_info_collector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/gpu/gpu_info_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/gpu/gpu_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/gpu/gpu_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/gpu/gpu_video_decoder.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/gpu/gpu_video_decoder.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/gpu/gpu_video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/gpu/gpu_video_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/command_buffer_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/gpu_channel_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/gpu_channel_host.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/renderer/gpu_video_decoder_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/gpu_video_decoder_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/gpu_video_decoder_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/gpu_video_service_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/gpu_video_service_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu_blacklist.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu_blacklist_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/gpu_message_filter.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M content/common/common_param_traits.h View 2 chunks +63 lines, -0 lines 0 comments Download
M content/common/common_param_traits.cc View 2 chunks +66 lines, -0 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
A + content/common/dx_diag_node.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/dx_diag_node.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/common/gpu_info.h View 3 chunks +4 lines, -5 lines 0 comments Download
A + content/common/gpu_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/common/gpu_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/common/gpu_messages.h View 3 chunks +107 lines, -11 lines 0 comments Download
M content/content_common.gypi View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years, 9 months ago (2011-03-10 22:10:45 UTC) #1
apatrick_chromium
checkdeps error: Illegal include: "gpu/ipc/gpu_command_buffer_traits.h" Because of no rule applying Illegal include: "gpu/command_buffer/common/command_buffer.h" Because of ...
9 years, 9 months ago (2011-03-10 22:42:49 UTC) #2
jam
9 years, 9 months ago (2011-03-10 22:47:04 UTC) #3
yep, have a fix locally (I send these reviews in parallel with waiting for
the try bot : ) )

On Thu, Mar 10, 2011 at 2:42 PM, <apatrick@chromium.org> wrote:

> checkdeps error:
>
> Illegal include: "gpu/ipc/gpu_command_buffer_traits.h"
>    Because of no rule applying
> Illegal include: "gpu/command_buffer/common/command_buffer.h"
>    Because of no rule applying
>
> Otherwise LGTM.
>
>
> http://codereview.chromium.org/6673003/
>

Powered by Google App Engine
This is Rietveld 408576698