Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Unified Diff: user_collector.h

Issue 6673002: crash-reporter: keep ignoring chrome crashes even on dev builds (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crash-reporter.git@master
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | user_collector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: user_collector.h
diff --git a/user_collector.h b/user_collector.h
index e46382cde0418add0fde13b0ae1a3aead33080f4..a231dd646b866a5d862b477ad7147acf3bf46385 100644
--- a/user_collector.h
+++ b/user_collector.h
@@ -63,6 +63,9 @@ class UserCollector : public CrashCollector {
FRIEND_TEST(UserCollectorTest, GetSymlinkTarget);
FRIEND_TEST(UserCollectorTest, GetUserInfoFromName);
FRIEND_TEST(UserCollectorTest, ParseCrashAttributes);
+ FRIEND_TEST(UserCollectorTest, ShouldDumpChromeOverridesDeveloperImage);
+ FRIEND_TEST(UserCollectorTest, ShouldDumpDeveloperImageOverridesConsent);
+ FRIEND_TEST(UserCollectorTest, ShouldDumpUseConsentProductionImage);
// Enumeration to pass to GetIdFromStatus. Must match the order
// that the kernel lists IDs in the status file.
@@ -114,6 +117,11 @@ class UserCollector : public CrashCollector {
bool ParseCrashAttributes(const std::string &crash_attributes,
pid_t *pid, int *signal,
std::string *kernel_supplied_name);
+ bool ShouldDump(bool has_owner_consent,
+ bool is_developer,
+ bool is_crash_test_in_progress,
+ const std::string &exec,
+ std::string *reason);
bool generate_diagnostics_;
std::string core_pattern_file_;
« no previous file with comments | « no previous file | user_collector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698