Make HDeoptimize to explicitly use environment values....

src/hydrogen.h

Index: src/hydrogen.h
===================================================================
--- src/hydrogen.h	(revision 7210)
+++ src/hydrogen.h	(working copy)
@@ -124,6 +124,14 @@
   void AddSimulate(int id) { AddInstruction(CreateSimulate(id)); }
   void AssignCommonDominator(HBasicBlock* other);
 
+  void FinishWithDeoptimization() {
+    Finish(CreateDeoptimize());

[Kevin Millikin (Chromium), 2011/03/17 05:31:02]

I'd rather not have these helpers.  It doesn't save anything over:

block->Finish(CreateDeoptimize());

which has the advantage of being explicit about what happens.  There are too
many minor variations on "Finish" already.

+  }
+
+  void FinishExitWithDeoptimization() {

[Kevin Millikin (Chromium), 2011/03/17 05:31:02]

There's no reason to have both "Finish" and "FinishExit" for this case.  It
should always be "FinishExit".

(Though, I don't know whey we even have FinishExit at all.  All it does is clear
the environment and call Finish.  I can't think of a reason why we need to do
that.  I'd be in favor of getting rid of FinishExit too.)

+    FinishExit(CreateDeoptimize());
+  }
+
   // Add the inlined function exit sequence, adding an HLeaveInlined
   // instruction and updating the bailout environment.
   void AddLeaveInlined(HValue* return_value, HBasicBlock* target);
@@ -146,6 +154,7 @@
   void AddDominatedBlock(HBasicBlock* block);
 
   HSimulate* CreateSimulate(int id);
+  HDeoptimize* CreateDeoptimize();
 
   int block_id_;
   HGraph* graph_;