chrome/renderer/render_view.cc - Issue 6672065: Support touch icon in FaviconHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/render_view.cc

Issue 6672065: Support touch icon in FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Only update the FAVICON data to the NavigationEntry. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/render_view.cc

diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc

index ab3d79a5f9bb23b234de26081e2fa48419b72dde..a408d98f8414b97929a4279c0d1ab8cd18e2118f 100644

--- a/chrome/renderer/render_view.cc

+++ b/chrome/renderer/render_view.cc

@@ -2183,6 +2183,8 @@ void RenderView::didStopLoading() {

// displayed when done loading. Ideally we would send notification when

// finished parsing the head, but webkit doesn't support that yet.

// The feed discovery code would also benefit from access to the head.

+ // TODO : Get both favicon and touch icon url, and send them to the browser.

sky 2011/03/18 17:33:37 This should only be done if needed.

GURL favicon_url(webview()->mainFrame()->favIconURL());

if (!favicon_url.is_empty())

Send(new ViewHostMsg_UpdateFaviconURL(routing_id_, page_id_, favicon_url));