chrome/browser/debugger/devtools_window.cc - Issue 6672065: Support touch icon in FaviconHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/debugger/devtools_window.cc

Issue 6672065: Support touch icon in FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Only update the FAVICON data to the NavigationEntry. Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/debugger/devtools_window.cc

diff --git a/chrome/browser/debugger/devtools_window.cc b/chrome/browser/debugger/devtools_window.cc

index 5e4b3246b9865231085fdc7103e2f7c028ac3e7b..04fc766d45c4a9bb09f3438e8d689aa527647dc1 100644

--- a/chrome/browser/debugger/devtools_window.cc

+++ b/chrome/browser/debugger/devtools_window.cc

@@ -75,8 +75,8 @@ DevToolsWindow::DevToolsWindow(Profile* profile,

// Wipe out page icon so that the default application icon is used.

NavigationEntry* entry = tab_contents_->controller().GetActiveEntry();

- entry->favicon().set_bitmap(SkBitmap());

- entry->favicon().set_is_valid(true);

+ entry->GetFavicon(history::FAVICON).set_bitmap(SkBitmap());

+ entry->GetFavicon(history::FAVICON).set_is_valid(true);

// Register on-load actions.

registrar_.Add(this,

« no previous file with comments | « no previous file | chrome/browser/favicon_delegate.h » ('j') | chrome/browser/favicon_helper.h » ('J')