chrome/browser/ui/webui/most_visited_handler.cc - Issue 6672065: Support touch icon in FaviconHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/most_visited_handler.cc

Issue 6672065: Support touch icon in FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compile error for clank mac and unit test memory leak Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/most_visited_handler.cc

diff --git a/chrome/browser/ui/webui/most_visited_handler.cc b/chrome/browser/ui/webui/most_visited_handler.cc

index 11f6e1b1b821382d7840e34b81771349d7c07049..99bac17a42167f82925f5d9de7ee572faad04103 100644

--- a/chrome/browser/ui/webui/most_visited_handler.cc

+++ b/chrome/browser/ui/webui/most_visited_handler.cc

@@ -27,6 +27,7 @@

#include "chrome/browser/ui/webui/new_tab_ui.h"

#include "chrome/browser/ui/webui/thumbnail_source.h"

#include "chrome/common/pref_names.h"

+#include "chrome/common/url_constants.h"

#include "content/browser/browser_thread.h"

#include "content/common/notification_source.h"

#include "content/common/notification_type.h"

@@ -68,8 +69,7 @@ WebUIMessageHandler* MostVisitedHandler::Attach(WebUI* web_ui) {

ThumbnailSource* thumbnail_src = new ThumbnailSource(profile);

profile->GetChromeURLDataManager()->AddDataSource(thumbnail_src);

- FaviconSource* favicon_src = new FaviconSource(profile);

- profile->GetChromeURLDataManager()->AddDataSource(favicon_src);

+ profile->GetChromeURLDataManager()->AddDataSource(new FaviconSource(profile));

// Get notifications when history is cleared.

registrar_.Add(this, NotificationType::HISTORY_URLS_DELETED,

« no previous file with comments | « chrome/browser/ui/web_applications/web_app_ui.cc ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »