Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: chrome/browser/favicon_helper.h

Issue 6672065: Support touch icon in FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_HELPER_H__ 5 #ifndef CHROME_BROWSER_FAVICON_HELPER_H__
6 #define CHROME_BROWSER_FAVICON_HELPER_H__ 6 #define CHROME_BROWSER_FAVICON_HELPER_H__
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/callback.h" 12 #include "base/callback.h"
13 #include "base/ref_counted.h" 13 #include "base/ref_counted.h"
14 #include "chrome/browser/favicon_service.h" 14 #include "chrome/browser/favicon_service.h"
15 #include "chrome/common/icon_messages.h"
15 #include "chrome/common/ref_counted_util.h" 16 #include "chrome/common/ref_counted_util.h"
16 #include "content/browser/cancelable_request.h" 17 #include "content/browser/cancelable_request.h"
17 #include "content/browser/tab_contents/tab_contents_observer.h" 18 #include "content/browser/tab_contents/tab_contents_observer.h"
18 #include "googleurl/src/gurl.h" 19 #include "googleurl/src/gurl.h"
19 20
20 class NavigationEntry; 21 class NavigationEntry;
21 class Profile; 22 class Profile;
22 class RefCountedMemory; 23 class RefCountedMemory;
23 class SkBitmap; 24 class SkBitmap;
24 class TabContents; 25 class TabContents;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 // OnFaviconData either updates the favicon of the NavigationEntry (if the 61 // OnFaviconData either updates the favicon of the NavigationEntry (if the
61 // db knew about the favicon), or requests the renderer to download the 62 // db knew about the favicon), or requests the renderer to download the
62 // favicon. 63 // favicon.
63 // 64 //
64 // When the renderer downloads the favicon SetFaviconImageData is invoked, 65 // When the renderer downloads the favicon SetFaviconImageData is invoked,
65 // at which point we update the favicon of the NavigationEntry and notify 66 // at which point we update the favicon of the NavigationEntry and notify
66 // the database to save the favicon. 67 // the database to save the favicon.
67 68
68 class FaviconHelper : public TabContentsObserver { 69 class FaviconHelper : public TabContentsObserver {
69 public: 70 public:
70 explicit FaviconHelper(TabContents* tab_contents); 71 enum Types {
72 FAVICON,
73 TOUCH,
74 };
75
76 FaviconHelper(TabContents* tab_contents, Types icon_type);
71 virtual ~FaviconHelper(); 77 virtual ~FaviconHelper();
72 78
73 // Initiates loading the favicon for the specified url. 79 // Initiates loading the favicon for the specified url.
74 void FetchFavicon(const GURL& url); 80 void FetchFavicon(const GURL& url);
75 81
76 // Initiates loading an image from given |image_url|. Returns a download id 82 // Initiates loading an image from given |image_url|. Returns a download id
77 // for caller to track the request. When download completes, |callback| is 83 // for caller to track the request. When download completes, |callback| is
78 // called with the three params: the download_id, a boolean flag to indicate 84 // called with the three params: the download_id, a boolean flag to indicate
79 // whether the download succeeds and a SkBitmap as the downloaded image. 85 // whether the download succeeds and a SkBitmap as the downloaded image.
80 // Note that |image_size| is a hint for images with multiple sizes. The 86 // Note that |image_size| is a hint for images with multiple sizes. The
81 // downloaded image is not resized to the given image_size. If 0 is passed, 87 // downloaded image is not resized to the given image_size. If 0 is passed,
82 // the first frame of the image is returned. 88 // the first frame of the image is returned.
83 typedef Callback3<int, bool, const SkBitmap&>::Type ImageDownloadCallback; 89 typedef Callback3<int, bool, const SkBitmap&>::Type ImageDownloadCallback;
84 int DownloadImage(const GURL& image_url, int image_size, 90 int DownloadImage(const GURL& image_url,
91 int image_size,
92 history::IconType icon_type,
85 ImageDownloadCallback* callback); 93 ImageDownloadCallback* callback);
86 94
87 // Message Handler. Must be public, because also called from 95 // Message Handler. Must be public, because also called from
88 // PrerenderContents. 96 // PrerenderContents.
89 void OnUpdateFaviconURL(int32 page_id, const GURL& icon_url); 97 void OnUpdateFaviconURL(int32 page_id,
98 const std::vector<FaviconURL>& candidates);
90 99
91 private: 100 private:
92 struct DownloadRequest { 101 struct DownloadRequest {
93 DownloadRequest() {} 102 DownloadRequest();
103
94 DownloadRequest(const GURL& url, 104 DownloadRequest(const GURL& url,
95 const GURL& image_url, 105 const GURL& image_url,
96 ImageDownloadCallback* callback) 106 ImageDownloadCallback* callback,
97 : url(url), 107 history::IconType icon_type);
98 image_url(image_url),
99 callback(callback) { }
100 108
101 GURL url; 109 GURL url;
102 GURL image_url; 110 GURL image_url;
103 ImageDownloadCallback* callback; 111 ImageDownloadCallback* callback;
112 history::IconType icon_type;
104 }; 113 };
105 114
115 static bool do_url_and_icon_match (const FaviconURL& favicon_url,
116 const GURL& url,
117 history::IconType icon_type) {
118 return favicon_url.icon_url == url &&
119 favicon_url.icon_type == static_cast<IconType>(icon_type);
120 }
121
106 // TabContentsObserver implementation. 122 // TabContentsObserver implementation.
107 virtual bool OnMessageReceived(const IPC::Message& message); 123 virtual bool OnMessageReceived(const IPC::Message& message);
108 124
109 void OnDidDownloadFavicon(int id, 125 void OnDidDownloadFavicon(int id,
110 const GURL& image_url, 126 const GURL& image_url,
111 bool errored, 127 bool errored,
112 const SkBitmap& image); 128 const SkBitmap& image);
113 129
114 // Return the NavigationEntry for the active entry, or NULL if the active 130 // Return the NavigationEntry for the active entry, or NULL if the active
115 // entries URL does not match that of the URL last passed to FetchFavicon. 131 // entries URL does not match that of the URL last passed to FetchFavicon.
116 NavigationEntry* GetEntry(); 132 NavigationEntry* GetEntry();
117 133
118 Profile* profile(); 134 Profile* profile();
119 135
120 FaviconService* GetFaviconService(); 136 FaviconService* GetFaviconService();
121 137
122 // See description above class for details. 138 // See description above class for details.
123 void OnFaviconDataForInitialURL(FaviconService::Handle handle, 139 void OnFaviconDataForInitialURL(FaviconService::Handle handle,
124 history::FaviconData favicon); 140 history::FaviconData favicon);
125 141
126 // If the favicon has expired, asks the renderer to download the favicon. 142 // If the favicon has expired, asks the renderer to download the favicon.
127 // Otherwise asks history to update the mapping between page url and icon 143 // Otherwise asks history to update the mapping between page url and icon
128 // url with a callback to OnFaviconData when done. 144 // url with a callback to OnFaviconData when done.
129 void DownloadFaviconOrAskHistory(NavigationEntry* entry); 145 void DownloadFaviconOrAskHistory(const GURL& page_url,
146 const GURL& icon_url,
147 history::IconType icon_type);
130 148
131 // See description above class for details. 149 // See description above class for details.
132 void OnFaviconData(FaviconService::Handle handle, 150 void OnFaviconData(FaviconService::Handle handle,
133 history::FaviconData favicon); 151 history::FaviconData favicon);
134 152
135 // Schedules a download for the specified entry. This adds the request to 153 // Schedules a download for the specified entry. This adds the request to
136 // download_requests_. 154 // download_requests_.
137 int ScheduleDownload(const GURL& url, const GURL& image_url, int image_size, 155 int ScheduleDownload(const GURL& url,
156 const GURL& image_url,
157 int image_size,
158 history::IconType icon_type,
138 ImageDownloadCallback* callback); 159 ImageDownloadCallback* callback);
139 160
140 // Sets the image data for the favicon. This is invoked asynchronously after 161 // Sets the image data for the favicon. This is invoked asynchronously after
141 // we request the TabContents to download the favicon. 162 // we request the TabContents to download the favicon.
142 void SetFavicon(const GURL& url, const GURL& icon_url, const SkBitmap& image); 163 void SetFavicon(const GURL& url,
164 const GURL& icon_url,
165 const SkBitmap& image,
166 history::IconType icon_type);
143 167
144 // Converts the image data to an SkBitmap and sets it on the NavigationEntry. 168 // Converts the FAVICON's image data to an SkBitmap and sets it on the
169 // NavigationEntry.
145 // If the TabContents has a delegate, it is notified of the new favicon 170 // If the TabContents has a delegate, it is notified of the new favicon
146 // (INVALIDATE_FAVICON). 171 // (INVALIDATE_FAVICON).
147 void UpdateFavicon(NavigationEntry* entry, 172 void UpdateFavicon(NavigationEntry* entry,
148 scoped_refptr<RefCountedMemory> data); 173 scoped_refptr<RefCountedMemory> data);
149 void UpdateFavicon(NavigationEntry* entry, const SkBitmap& image); 174 void UpdateFavicon(NavigationEntry* entry, const SkBitmap& image);
150 175
151 // Scales the image such that either the width and/or height is 16 pixels 176 // Scales the image such that either the width and/or height is 16 pixels
152 // wide. Does nothing if the image is empty. 177 // wide. Does nothing if the image is empty.
153 SkBitmap ConvertToFaviconSize(const SkBitmap& image); 178 SkBitmap ConvertToFaviconSize(const SkBitmap& image);
154 179
155 // Returns true if the favicon should be saved. 180 // Returns true if the favicon should be saved.
156 bool ShouldSaveFavicon(const GURL& url); 181 bool ShouldSaveFavicon(const GURL& url);
157 182
183 // Return the current candidate if any.
184 FaviconURL* current_candidate() {
185 return (urls_.size() > current_url_index_) ?
186 &urls_[current_url_index_] : NULL;
187 }
188
158 // Used for history requests. 189 // Used for history requests.
159 CancelableRequestConsumer cancelable_consumer_; 190 CancelableRequestConsumer cancelable_consumer_;
160 191
161 // URL of the page we're requesting the favicon for. 192 // URL of the page we're requesting the favicon for.
162 GURL url_; 193 GURL url_;
163 194
164 // Whether we got the url for the page back from the renderer.
165 // See "Favicon Details" in tab_contents.cc for more details.
166 bool got_favicon_url_;
167
168 // Whether we got the initial response for the favicon back from the renderer. 195 // Whether we got the initial response for the favicon back from the renderer.
169 // See "Favicon Details" in tab_contents.cc for more details. 196 // See "Favicon Details" in tab_contents.cc for more details.
170 bool got_favicon_from_history_; 197 bool got_favicon_from_history_;
171 198
172 // Whether the favicon is out of date. If true, it means history knows about 199 // Whether the favicon is out of date. If true, it means history knows about
173 // the favicon, but we need to download the favicon because the icon has 200 // the favicon, but we need to download the favicon because the icon has
174 // expired. 201 // expired.
175 // See "Favicon Details" in tab_contents.cc for more details. 202 // See "Favicon Details" in tab_contents.cc for more details.
176 bool favicon_expired_; 203 bool favicon_expired_;
177 204
178 // Requests to the renderer to download favicons. 205 // Requests to the renderer to download favicons.
179 typedef std::map<int, DownloadRequest> DownloadRequests; 206 typedef std::map<int, DownloadRequest> DownloadRequests;
180 DownloadRequests download_requests_; 207 DownloadRequests download_requests_;
181 208
209 // The combination of the supported icon types.
210 const int icon_types_;
211
212 // The prioritized favicon candidates from the page back from the renderer.
213 std::vector<FaviconURL> urls_;
214
215 // The current candidate's index in urls_.
216 size_t current_url_index_;
217
218 // The FaviconData from history.
219 history::FaviconData history_icon_;
220
221 // The preferred icon size for supported icon types.
222 int preferred_icon_size_;
223
182 DISALLOW_COPY_AND_ASSIGN(FaviconHelper); 224 DISALLOW_COPY_AND_ASSIGN(FaviconHelper);
183 }; 225 };
184 226
185 #endif // CHROME_BROWSER_FAVICON_HELPER_H__ 227 #endif // CHROME_BROWSER_FAVICON_HELPER_H__
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698