Support touch icon in FaviconHelper

ui/gfx/favicon_size.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_FAVICON_SIZE_H_
 #define UI_GFX_FAVICON_SIZE_H_
 #pragma once
 
 #include "base/compiler_specific.h"
 
 // Size (along each axis) of the favicon.
 const int kFaviconSize = 16;
 
 // If the width or height is bigger than the favicon size, a new width/height
 // is calculated and returned in width/height that maintains the aspect
 // ratio of the supplied values.
-static void calc_favicon_target_size(int* width, int* height) ALLOW_UNUSED;
+static void calc_favicon_target_size(int target_size,

[sky, 2011/03/23 22:49:31]

Do we really need these changes? Aren't you still always passing in
kFaviconSize?

[michaelbai, 2011/03/23 23:26:49]

I thought it might useful for touch_icon in the future. Reverted.

+                                     int* width,
+                                     int* height) ALLOW_UNUSED;
 
 // static
-void calc_favicon_target_size(int* width, int* height) {
-  if (*width > kFaviconSize || *height > kFaviconSize) {
+void calc_favicon_target_size(int target_size, int* width, int* height) {
+  if (*width > target_size || *height > target_size) {
     // Too big, resize it maintaining the aspect ratio.
     float aspect_ratio = static_cast<float>(*width) /
                          static_cast<float>(*height);
-    *height = kFaviconSize;
+    *height = target_size;
     *width = static_cast<int>(aspect_ratio * *height);
-    if (*width > kFaviconSize) {
-      *width = kFaviconSize;
+    if (*width > target_size) {
+      *width = target_size;
       *height = static_cast<int>(*width / aspect_ratio);
     }
   }
 }
 
 #endif  // UI_GFX_FAVICON_SIZE_H_