Support touch icon in FaviconHelper

content/renderer/render_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 2103 matching lines @@
     return;
   }
 
   is_loading_ = false;
 
   // NOTE: For now we're doing the safest thing, and sending out notification
   // when done loading. This currently isn't an issue as the favicon is only
   // displayed when done loading. Ideally we would send notification when
   // finished parsing the head, but webkit doesn't support that yet.
   // The feed discovery code would also benefit from access to the head.
+
+  // TODO : Get both favicon and touch icon url, and send them to the browser.

[sky, 2011/03/22 19:48:48]

You should only do this if the browser cares about them. You'll need something
similar to defaults, or perhaps you can pass it down as a pref. I'm not sure
what's the preferred approach.

[michaelbai, 2011/03/22 23:59:03]

I will revisit it after I get the webkit part done.

Thanks

   GURL favicon_url(webview()->mainFrame()->favIconURL());
-  if (!favicon_url.is_empty())
-    Send(new ViewHostMsg_UpdateFaviconURL(routing_id_, page_id_, favicon_url));
+  if (!favicon_url.is_empty()) {
+    std::vector<FaviconURL> urls;
+    urls.push_back(FaviconURL(favicon_url, FAVICON));
+    Send(new ViewHostMsg_UpdateFaviconURL(routing_id_, page_id_, urls));
+  }
 
   AddGURLSearchProvider(webview()->mainFrame()->openSearchDescriptionURL(),
                         ViewHostMsg_PageHasOSDD_Type::Autodetected());
 
   Send(new ViewHostMsg_DidStopLoading(routing_id_));
 
   if (load_progress_tracker_ != NULL)
     load_progress_tracker_->DidStopLoading();
 
   MessageLoop::current()->PostDelayedTask(
@@ skipping 1195 matching lines @@
 
 void RenderView::didReceiveTitle(WebFrame* frame, const WebString& title) {
   UpdateTitle(frame, title);
 
   // Also check whether we have new encoding name.
   UpdateEncoding(frame, frame->view()->pageEncoding().utf8());
 }
 
 void RenderView::didChangeIcons(WebFrame* frame) {
   if (!frame->parent()) {
-    Send(new ViewHostMsg_UpdateFaviconURL(
-        routing_id_,
-        page_id_,
-        frame->favIconURL()));
+    std::vector<FaviconURL> urls;
+    urls.push_back(FaviconURL(frame->favIconURL(), FAVICON));
+    Send(new ViewHostMsg_UpdateFaviconURL(routing_id_, page_id_, urls));
   }
 }
 
 void RenderView::didFinishDocumentLoad(WebFrame* frame) {
   WebDataSource* ds = frame->dataSource();
   NavigationState* navigation_state = NavigationState::FromDataSource(ds);
   DCHECK(navigation_state);
   navigation_state->set_finish_document_load_time(Time::Now());
 
   Send(new ViewHostMsg_DocumentLoadedInFrame(routing_id_, frame->identifier()));
@@ skipping 2056 matching lines @@
     const webkit_glue::CustomContextMenuContext& custom_context) {
   if (custom_context.is_pepper_menu)
     pepper_delegate_.OnContextMenuClosed(custom_context);
   else
     context_menu_node_.reset();
 }
 
 void RenderView::OnNetworkStateChanged(bool online) {
   WebNetworkStateNotifier::setOnLine(online);
 }