Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6672057: Move all the message files in chrome that belong in content. (Closed)

Created:
9 years, 9 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move all the message files in chrome that belong in content. TBR=avi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78435

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -1408 lines) Patch
M chrome/browser/idbbindingutilities_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/utility_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 7 chunks +0 lines, -16 lines 0 comments Download
D chrome/common/clipboard_messages.h View 1 chunk +0 lines, -64 lines 0 comments Download
M chrome/common/common_message_generator.h View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/common/dom_storage_common.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/common/dom_storage_messages.h View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/common/indexed_db_key.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/common/indexed_db_key.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/common/indexed_db_messages.h View 1 chunk +0 lines, -433 lines 0 comments Download
D chrome/common/indexed_db_param_traits.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/common/indexed_db_param_traits.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/common/pepper_file_messages.h View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/common/pepper_file_messages.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/common/pepper_messages.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/common/pepper_messages.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/common/render_messages_params.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/serialized_script_value.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/common/serialized_script_value.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/common/speech_input_messages.h View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/common/speech_input_result.h View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/common/utility_messages.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/indexed_db_dispatcher.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/pepper_plugin_delegate_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_webidbcursor_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/renderer_webidbcursor_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_webidbdatabase_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_webidbindex_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_webidbobjectstore_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/renderer_webidbtransaction_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_webstoragearea_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_webstoragenamespace_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/render_view_fake_resources_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/speech_input_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/speech_input_dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/render_view_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/utility/utility_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/browser_webkitclient_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/dom_storage_area.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/dom_storage_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/dom_storage_message_filter.h View 1 chunk +1 line, -2 lines 2 comments Download
M content/browser/in_process_webkit/dom_storage_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/dom_storage_namespace.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_callbacks.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_database_callbacks.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_key_utility_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_transaction_callbacks.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper_file_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/speech/speech_input_dispatcher_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_input_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognition_request.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 2 chunks +1 line, -1 line 0 comments Download
A + content/common/clipboard_messages.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +6 lines, -2 lines 0 comments Download
A + content/common/dom_storage_common.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/dom_storage_messages.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/common/indexed_db_key.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/indexed_db_key.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/common/indexed_db_messages.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/common/indexed_db_param_traits.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/indexed_db_param_traits.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/common/pepper_file_messages.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/common/pepper_file_messages.cc View 1 chunk +1 line, -3 lines 0 comments Download
A + content/common/pepper_messages.h View 2 chunks +4 lines, -5 lines 0 comments Download
A + content/common/pepper_messages.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + content/common/serialized_script_value.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/serialized_script_value.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/common/speech_input_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
A + content/common/speech_input_result.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/content_common.gypi View 5 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
9 years, 9 months ago (2011-03-16 21:08:43 UTC) #1
Tom Sepez
LGTM. http://codereview.chromium.org/6672057/diff/73/content/browser/in_process_webkit/dom_storage_message_filter.h File content/browser/in_process_webkit/dom_storage_message_filter.h (right): http://codereview.chromium.org/6672057/diff/73/content/browser/in_process_webkit/dom_storage_message_filter.h#newcode16 content/browser/in_process_webkit/dom_storage_message_filter.h:16: #include "content/common/dom_storage_common.h" removal of ipc_message.h? Looks like some ...
9 years, 9 months ago (2011-03-16 21:19:58 UTC) #2
jam
9 years, 9 months ago (2011-03-16 21:23:21 UTC) #3 
http://codereview.chromium.org/6672057/diff/73/content/browser/in_process_web...
File content/browser/in_process_webkit/dom_storage_message_filter.h (right):

http://codereview.chromium.org/6672057/diff/73/content/browser/in_process_web...
content/browser/in_process_webkit/dom_storage_message_filter.h:16: #include
"content/common/dom_storage_common.h"
On 2011/03/16 21:19:58, Tom Sepez wrote:
> removal of ipc_message.h?  Looks like some of the methods below refernce this.

no need to include ipc_message when including browser_message_filter

Powered by Google App Engine
This is Rietveld 408576698