Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: include/v8-debug.h

Issue 6672044: [Isolates] Fix debugger and termination APIs callable from other threads. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/isolates
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/v8.h ('K') | « include/v8.h ('k') | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-debug.h
diff --git a/include/v8-debug.h b/include/v8-debug.h
index f17b848550d0f0736ebda3b7dfa3cd506227f4c4..607263145fa2bd2cf4620c13b33ce924dbe5ef09 100755
--- a/include/v8-debug.h
+++ b/include/v8-debug.h
@@ -254,16 +254,17 @@ class EXPORT Debug {
Handle<Value> data = Handle<Value>());
// Schedule a debugger break to happen when JavaScript code is run.
- static void DebugBreak();
+ static void DebugBreak(Isolate* isolate = NULL);
Vitaly Repeshko 2011/03/16 18:08:21 Please document that these functions use the defau
Mads Ager (chromium) 2011/03/16 18:52:47 Done.
// Remove scheduled debugger break if it has not happened yet.
- static void CancelDebugBreak();
+ static void CancelDebugBreak(Isolate* isolate = NULL);
// Break execution of JavaScript (this method can be invoked from a
// non-VM thread) for further client command execution on a VM
// thread. Client data is then passed in EventDetails to
// EventCallback at the moment when the VM actually stops.
- static void DebugBreakForCommand(ClientData* data = NULL);
+ static void DebugBreakForCommand(ClientData* data = NULL,
+ Isolate* isolate = NULL);
// Message based interface. The message protocol is JSON. NOTE the message
// handler thread is not supported any more parameter must be false.
« include/v8.h ('K') | « include/v8.h ('k') | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698