Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 6672007: Add logs for update_engine and image_to_live to test artifacts. (Closed)

Created:
9 years, 9 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
dgarrett
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Add logs for update_engine, devserver, and cros_run_vm_update to test artifacts. Change-Id: Ib5617612be38bb6d7dafcb2edab887c998a676ab BUG=chromium-os:12951 TEST=Ran it with Simple. Saw logs generated (1_update) and in root/dev_server.log. Ran unittests for cros_build_lib. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f53a8c7 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bc4c157

Patch Set 1 #

Patch Set 2 : Nit #

Patch Set 3 : Add unittest #

Patch Set 4 : Fix bug in RunCommand #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -20 lines) Patch
M bin/au_test_harness/au_test.py View 1 chunk +6 lines, -2 lines 0 comments Download
M bin/au_test_harness/au_worker.py View 1 2 chunks +16 lines, -6 lines 0 comments Download
M bin/au_test_harness/cros_au_test_harness.py View 1 chunk +2 lines, -1 line 0 comments Download
M bin/au_test_harness/dev_server_wrapper.py View 3 chunks +6 lines, -2 lines 0 comments Download
M bin/au_test_harness/vm_au_worker.py View 5 chunks +9 lines, -4 lines 0 comments Download
M bin/cros_run_vm_update View 2 chunks +3 lines, -0 lines 0 comments Download
M lib/cros_build_lib.py View 1 2 3 5 chunks +30 lines, -5 lines 0 comments Download
M lib/cros_build_lib_unittest.py View 1 2 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sosa
9 years, 9 months ago (2011-03-10 23:29:43 UTC) #1
dgarrett
LGTM with the note.... Can you add a unit test for the new option to ...
9 years, 9 months ago (2011-03-11 01:43:52 UTC) #2
sosa
Added unittest. Pushing. Also ... for RunCommand ... if you can suggest an interface, we ...
9 years, 9 months ago (2011-03-11 23:41:50 UTC) #3
sosa
This broke the build because I needed to change the test root (now I assume ...
9 years, 9 months ago (2011-03-12 00:23:59 UTC) #4
sosa
PTAL. Fixed bug in RunCommand (cros_build_lib.py patch 3)
9 years, 9 months ago (2011-03-12 01:09:53 UTC) #5
dgarrett
9 years, 9 months ago (2011-03-12 02:16:42 UTC) #6
On 2011/03/12 01:09:53, sosa wrote:
> PTAL.  Fixed bug in RunCommand (cros_build_lib.py patch 3)

I'd read that code, but never saw the bug until your change.

Powered by Google App Engine
This is Rietveld 408576698