Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 6672003: CHROMIUM: qcusbnet: Add gobi3k support. (Closed)

Created:
9 years, 9 months ago by Elly Fong-Jones
Modified:
9 years, 4 months ago
Reviewers:
Jason Glasgow
CC:
chromium-os-reviews_chromium.org, vb+kernel_google.com, Olof Johansson, sleffler+cc_chromium.org, msb+croskernel_chromium.org
Visibility:
Public.

Description

CHROMIUM: qcusbnet: Add gobi3k support. This entails: 1) Adding a couple of new vid:pid pairs for known Gobi3k devices. 2) Handling the extra USB interface gobi3ks have 3) Installing a proper 'parent' pointer to help udev emit the correct number of device events, and 4) Changing the driver's registration name. The latter change was requested by upstream when I first submitted this driver. It is correct, in that the driver's name should reflect that it does not just drive gobi2ks, but it will require changes in userspace to match. BUG=chromium-os:12380 TEST=Adhoc ls /dev/qcqmi* with both a g2k and g3k present; try 'gobi3k list', too. Change-Id: I0e86fcbce22f3a1f3fd58caf0e8d47e39a1af9ed Signed-off-by: Elly Jones <ellyjones@chromium.org>; Signed-off-by: Jason Glasgow <jglasgow@chromium.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b4fd3f9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes per jglasgow. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M drivers/net/usb/gobi/qcusbnet.c View 1 4 chunks +8 lines, -4 lines 0 comments Download
M drivers/net/usb/gobi/qmidevice.c View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elly Fong-Jones
9 years, 9 months ago (2011-03-10 20:48:01 UTC) #1
Jason Glasgow
9 years, 9 months ago (2011-03-10 20:58:40 UTC) #2
LGTM modulo a nit.

http://codereview.chromium.org/6672003/diff/1/drivers/net/usb/gobi/qcusbnet.c
File drivers/net/usb/gobi/qcusbnet.c (right):

http://codereview.chromium.org/6672003/diff/1/drivers/net/usb/gobi/qcusbnet.c...
drivers/net/usb/gobi/qcusbnet.c:24: #define DRIVER_VERSION "1.0.110"
As you change the driver do you want to change the version string?

http://codereview.chromium.org/6672003/diff/1/drivers/net/usb/gobi/qcusbnet.c...
drivers/net/usb/gobi/qcusbnet.c:26: #define DRIVER_DESC "QCUSBNet2k"
Is 2k correct?  gobi?

Powered by Google App Engine
This is Rietveld 408576698