Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 6670133: Fix NSS in single process mode (Closed)

Created:
9 years, 8 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
Reviewers:
awong
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix NSS in single process mode We used to initialize NSS without DB in single process mode. This caused going to https site faile in single process mode. This patch fixes it. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/renderer/render_process_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Alpha Left Google
9 years, 8 months ago (2011-03-31 18:53:30 UTC) #1
awong
9 years, 8 months ago (2011-03-31 18:56:12 UTC) #2
LGTM

On Thu, Mar 31, 2011 at 2:53 PM, <hclam@chromium.org> wrote:

> Reviewers: awong,
>
> Description:
> Fix NSS in single process mode
>
> We used to initialize NSS without DB in single process mode. This caused
> going
> to https site faile in single process mode. This patch fixes it.
>
> BUG=None
> TEST=None
>
>
> Please review this at http://codereview.chromium.org/6670133/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/renderer/render_process_impl.cc
>
>
> Index: chrome/renderer/render_process_impl.cc
> diff --git a/chrome/renderer/render_process_impl.cc
> b/chrome/renderer/render_process_impl.cc
> index
>
9d63c77ba467490bc6bd783438f9074bab3ee585..0266fbb9511394dac0df699a035e8a9eb5653c18
> 100644
> --- a/chrome/renderer/render_process_impl.cc
> +++ b/chrome/renderer/render_process_impl.cc
> @@ -161,7 +161,9 @@ RenderProcessImpl::RenderProcessImpl()
>
>  #if defined(OS_LINUX)
>   // Remoting requires NSS to function properly.
> -  if (command_line.HasSwitch(switches::kEnableRemoting)) {
> +
> +  if (!command_line.HasSwitch(switches::kSingleProcess) &&
> +      command_line.HasSwitch(switches::kEnableRemoting)) {
>  #if defined(USE_NSS)
>     // We are going to fork to engage the sandbox and we have not loaded
>     // any security modules so it is safe to disable the fork check in NSS.
>
>
>

Powered by Google App Engine
This is Rietveld 408576698