net/net.gyp - Issue 6670085: FTP: Detect the character encoding only after the entire listing is received.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/net.gyp

Issue 6670085: FTP: Detect the character encoding only after the entire listing is received. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update histograms for SERVER_UNKNOWN Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/ftp/ftp_directory_listing_parser_vms_unittest.cc ('K') | « net/ftp/ftp_directory_listing_parser_windows_unittest.cc ('k') | webkit/glue/ftp_directory_listing_response_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/net.gyp

diff --git a/net/net.gyp b/net/net.gyp

index 3c3e44edea128768b18a124251616bd7273988cf..3e925750359838082231f0badcaecbeae2684c41 100644

--- a/net/net.gyp

+++ b/net/net.gyp

@@ -415,8 +415,6 @@

'ftp/ftp_auth_cache.h',

'ftp/ftp_ctrl_response_buffer.cc',

'ftp/ftp_ctrl_response_buffer.h',

- 'ftp/ftp_directory_listing_buffer.cc',

- 'ftp/ftp_directory_listing_buffer.h',

'ftp/ftp_directory_listing_parser.cc',

'ftp/ftp_directory_listing_parser.h',

'ftp/ftp_directory_listing_parser_ls.cc',

@@ -908,9 +906,9 @@

'disk_cache/storage_block_unittest.cc',

'ftp/ftp_auth_cache_unittest.cc',

'ftp/ftp_ctrl_response_buffer_unittest.cc',

- 'ftp/ftp_directory_listing_buffer_unittest.cc',

'ftp/ftp_directory_listing_parser_ls_unittest.cc',

'ftp/ftp_directory_listing_parser_netware_unittest.cc',

+ 'ftp/ftp_directory_listing_parser_unittest.cc',

'ftp/ftp_directory_listing_parser_vms_unittest.cc',

'ftp/ftp_directory_listing_parser_windows_unittest.cc',

'ftp/ftp_network_transaction_unittest.cc',